On 01/23/2013 09:46 PM, IOhannes zmölnig wrote:
On 12/09/2012 07:54 PM, Hans-Christoph Steiner wrote:
Hey Roland,
Good to see you working on Pd too :) About your patch, I think
increasing MAXPDSTRING is dangerous because Pd uses MAXPDSTRING as the
max path length as well. I think Debian's maximum path length is quite
a bit shorter than 10000 bytes. Its not a good situation, I know, but
that's how it is.
what are the problems you expect?
if the user constructs a filename that is longer than MAX_PATH (which
won't refer to any file on the filesystem anyhow), will that lead to
some buffer overflow problem?
or will (f)open simply fail to open the given file?
a quick test seems to confirm this.
whenever i provide a filename that is longer than 4096 bytes (which is
PATH_MAX), open() fails, even if the file exists. (obviously, this means
that files can have longer full paths than 4096 chars, but this is just
an aside)
since this behaviour is regardless of the length of my character array,
i don't see a compelling reason to not increase MAXPDSTRING to 10000.
famsdr
IOhannes
--
To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
