FYI
--- Begin Message ---
This message was created automatically by mail delivery software.
A message that you sent could not be delivered to one or more of its
recipients. This is a permanent error. The following address(es) failed:
[email protected]
SMTP error from remote mail server after RCPT
TO:<[email protected]>:
host mx1.free.fr [212.27.48.6]: 550 Too many spams from your IP
(70.103.162.29), please visit http://postmaster.free.fr/
------ This is a copy of the message, including all the headers. ------
Return-path: <[email protected]>
Received: from mail-la0-f52.google.com ([209.85.215.52])
by master.debian.org with esmtps (TLS1.0:RSA_ARCFOUR_SHA1:16)
(Exim 4.72)
(envelope-from <[email protected]>)
id 1Tdv0o-0003CH-8c
for [email protected]; Thu, 29 Nov 2012 03:42:06 +0000
Received: by mail-la0-f52.google.com with SMTP id l5so9375554lah.25
for <[email protected]>; Wed, 28 Nov 2012 19:41:59 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20120113;
h=mime-version:in-reply-to:references:date:message-id:subject:from:to
:cc:content-type;
bh=2dDXqecF9Wcu7/e90Tsfk4tPf4X4MZsyGrsFsjOWSxA=;
b=dutSNX582qiDTHr4RWg1532+aiRUk17RLxUXcPtrFy/3uAr8ZHq1veWLEqx+Iacn6/
qgafQb0SGBrULbGmZxqdsa4jhMKay82wLjNBQ6DzXO5z0qFtZ7bv1/RQiClJrRanZE0Q
21cgBedxe4a2h9c33UnC2l8Ip8Db0IaqNorOForDze2kmIbliWsA2BlbjBNFJg9dY3G/
fMUQhraXS3Gm2delOKnluGkZ36xszs69fThnHeQ8yQY8RW1m6x27yA8Tt4ue/ZilnCVR
W3ejWuaRKF0yHXAtSuaS+KQXU2uWcMuEk4lBj/pXBpZWeTAFv746CEUEJ3zCZwJ+zn9S
4F6A==
MIME-Version: 1.0
Received: by 10.112.25.68 with SMTP id a4mr8902934lbg.10.1354160519141; Wed,
28 Nov 2012 19:41:59 -0800 (PST)
Received: by 10.112.61.65 with HTTP; Wed, 28 Nov 2012 19:41:59 -0800 (PST)
In-Reply-To: <20121128161719.10559.30276.reportbug@pegase>
References: <20121128161719.10559.30276.reportbug@pegase>
Date: Wed, 28 Nov 2012 19:41:59 -0800
Message-ID: <CAFzf2Xw_M5yYg7tqcbd8C0T3rybWxBNC+r66GCQumL=-qmc...@mail.gmail.com>
Subject: Re: Bug#679198: bash: [on native FreeBSD] unable to set FD_CLOEXEC flag
From: Jonathan Nieder <[email protected]>
To: Nicolas Boulenguez <[email protected]>
Cc: [email protected]
Content-Type: text/plain; charset=UTF-8
Nicolas Boulenguez wrote:
> If I understand well fcntl(2), the following patch may solve this bug.
> Stefan, would you please try to rebuild and test?
>
> --- bash.preinst-lib.c 2012-11-28 15:56:04.000000000 +0100
> +++ bash.preinst-lib.c.new 2012-11-28 17:07:09.000000000 +0100
> @@ -60,8 +60,8 @@
>
> void set_cloexec(int fd)
> {
> - int flags = fcntl(fd, F_GETFL);
> - if (flags < 0 || fcntl(fd, F_SETFL, flags | FD_CLOEXEC))
> + int flags = fcntl(fd, F_GETFD);
> + if (flags < 0 || fcntl(fd, F_SETFD, flags | FD_CLOEXEC))
> die_errno("cannot set close-on-exec flag");
Good eyes. Thanks for figuring it out.
For what it's worth,
Reviewed-by: Jonathan Nieder <[email protected]>
--- End Message ---
