-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
severity 690851 important
kthxbye
Hi,
in the ocurse of the BSP Essen I took a close look at this report and the
proposed patch.
First of all, I am downgrading the severity of the bug to important to
remove it from the RC list. The background is that the changes are most
likely not trivial enough to get a freeze exception for wheezy and the
issue is not critical enough to justify it as RC.
Looking at the code, I have a few questions:
addrs = None
try:
_ttl, addrs = resolve_ipv4(hostname)
except:
_ttl, addrs = resolve_ipv6(hostname)
Is preferring IPv4 over IPv6 the expected behaviour? It diverts from the
normal behaviour of other code.
if ipv4_res is not None:
for res in ipv4_res:
(et al), this looks the same as what was there before, but it is a bug.
The ipv4_res could be False, which is also not iterable.
if ipv4_res:
would be better, proper exception handling would be best.
- -nik
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (GNU/Linux)
iQFOBAEBAgA4BQJQsi5oMRpodHRwczovL3d3dy5kb21pbmlrLWdlb3JnZS5kZS9n
cGctcG9saWN5LnR4dC5hc2MACgkQWfyOHW8qgAFMMwf/ewJ0odjq3dca2c2ZT8vv
6kPOwtGCn8Zfv6fUuhoYibQ2fR8AHcRViV0Juq3H5p0XIB47Nkoiy9YZQhgy5tx4
+LJsSFgGoSOjl2wXB4hVEQaYLCU75t1D7KZapYl6TR+7RR6tvtbV67sf4RI646B2
gerXzRyz2ARTvv5qjlscjiAJIJpo6n5dIDfiQ7IrowtdWWoWQw/B/l0XNhFkyMFU
3wwID7ecHtfGYrXwFvI0Lu0dp3niul2TN3BDZyyhKXCTKYVR+XXDCwv+QGLD8sbX
ctXutuxac3jsfX6/38PnSD1T5vU3xndQwQV8AV4bu48358ANSttG94uPDOv3LRJx
rg==
=d1cd
-----END PGP SIGNATURE-----
--
To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
