Your message dated Tue, 30 Oct 2012 16:47:33 +0000
with message-id <e1tteyt-000500...@franck.debian.org>
and subject line Bug#688069: fixed in liblocale-subcountry-perl 1.56-2
has caused the Debian Bug report #688069,
regarding liblocale-subcountry-perl: Version checks fail ("our $VERSION" moved 
before "package Locale::SubCountry")
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
688069: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=688069
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: liblocale-subcountry-perl
Version: 1.56-1
Severity: serious
Tags: upstream patch
Justification: (Team) Package maintainer's opinion - package unsuitable for 
release

$ perl -e 'use Locale::SubCountry 54'
Locale::SubCountry does not define $Locale::SubCountry::VERSION--version check 
failed at -e line 1.

Sometime after version 1.50, "our $VERSION = 1.xx" was moved to the top of
the code, above any "package" declaration.  It is therefore not declaring
$Locale::SubCountry::VERSION, and previously-working version checks like
"use Locale::SubCountry 1.42" now throw a fatal error.

The patch below adds a "package Locale::SubCountry" to the beginning of the
code.  This seems like typical / best practice for modules, to avoid any
symbol exports from the intial "use" statements from polluting the main::
namespace.



--- SubCountry.pm.ORIG  2012-09-18 13:02:15.702774878 -0700
+++ SubCountry.pm       2012-09-18 13:30:04.351443803 -0700
@@ -314,6 +314,8 @@
 
 
#-------------------------------------------------------------------------------
 
+package Locale::SubCountry;
+
 use strict;
 use warnings;
 use locale;



-- System Information:
Debian Release: wheezy/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'testing'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 3.2.0-3-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages liblocale-subcountry-perl depends on:
ii  perl  5.14.2-13

liblocale-subcountry-perl recommends no packages.

liblocale-subcountry-perl suggests no packages.

-- no debconf information


-- 
Ivan Kohler
President and Head Geek, Freeside Internet Services, Inc.  http://freeside.biz/
Debian GNU/Linux developer  |  CPAN author  |  cat person  |  ski addict

--- End Message ---
--- Begin Message ---
Source: liblocale-subcountry-perl
Source-Version: 1.56-2

We believe that the bug you reported is fixed in the latest version of
liblocale-subcountry-perl, which is due to be installed in the Debian FTP 
archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 688...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
gregor herrmann <gre...@debian.org> (supplier of updated 
liblocale-subcountry-perl package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Tue, 30 Oct 2012 17:44:18 +0100
Source: liblocale-subcountry-perl
Binary: liblocale-subcountry-perl
Architecture: source all
Version: 1.56-2
Distribution: unstable
Urgency: low
Maintainer: Debian Perl Group <pkg-perl-maintain...@lists.alioth.debian.org>
Changed-By: gregor herrmann <gre...@debian.org>
Description: 
 liblocale-subcountry-perl - module for converting state/province names to/from 
code
Closes: 688069
Changes: 
 liblocale-subcountry-perl (1.56-2) unstable; urgency=low
 .
   * Add patch package.patch from Ivan Kohler: add a package declaration.
     (Closes: #688069)
   * Bump Standards-Version to 3.9.4 (no changes).
Checksums-Sha1: 
 45f73d9716393a62a1a41808ee16eeefa2fdea00 2331 
liblocale-subcountry-perl_1.56-2.dsc
 ef351868e0ae20dbdf00bef600ba789eadc2bf1c 4151 
liblocale-subcountry-perl_1.56-2.debian.tar.gz
 4f5fefa8f0d3b869bacd38769315e643e0f99984 83402 
liblocale-subcountry-perl_1.56-2_all.deb
Checksums-Sha256: 
 d7a636c9929b58eb6216e8baae22d3cfd7353546b3f2fa188dcb7891a562b780 2331 
liblocale-subcountry-perl_1.56-2.dsc
 7760a8978b09fe6f7151a95a7dcdff864277511d1e616697c4799ecedc2cb6ad 4151 
liblocale-subcountry-perl_1.56-2.debian.tar.gz
 fe6e2866463b41fb5bf1ba924b6140ac8a6d8747d8b306dc3cc823da90f166c0 83402 
liblocale-subcountry-perl_1.56-2_all.deb
Files: 
 bf92a8c956005169d3540250581da96b 2331 perl optional 
liblocale-subcountry-perl_1.56-2.dsc
 ac5a6640d5b3bd0ffc8bacc5c273f11a 4151 perl optional 
liblocale-subcountry-perl_1.56-2.debian.tar.gz
 0c5570bed59954cd13f93794a1aac155 83402 perl optional 
liblocale-subcountry-perl_1.56-2_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)

iQIcBAEBCAAGBQJQkAQEAAoJELs6aAGGSaoGqQYP/iUaPSDkAqn21yWVRKdmQGj8
/Hpt37aMTUU/2/6Ub6KaL+NtS4GQbfY57MVh79Vj1VCs7GDkxs6fnAm7gr9gsUfo
+rrMtU69wznr6batT2Xc0UGXakomyWd8bbRG3euHzU7kAS/HQTBk7Pzn4AYukgAs
95Ck1fno42knT+P4K4iJdqzvzzaNhuGoKtslok8gkPmopl1KWw2n2SnWW828ne+M
OxvbN4UMEhY+vUwzd4VLI1PRJ1zEA/8gBW4ds6lXCpCh7uTIvkQVpJQCVHjAipmq
+wY3tzojOQa9LFrHz7cjaUqSd0hgp57IblOmHx1uGzkIDF62hrDiwXp1ZKZvdFlO
htYE0MZTslCaoND8iddSAgyqVIW0dgsl8xbBn6iLN2IUfr+RWFrtFh5POpg+TE37
O9Hn6Ka9W6AAct98rYObt91gudAVJc0vYBb6FzfhfdEiIvYs+a3De/miDXmzSX4U
DZLR4dFzKwJ3PTZgIijqocwF00iFn0qxqJeqL0V15+y0W53T913Z8kFMIFso9LJR
5rPDz2wThdC0wmvUOUJh07WWlhcwt4e2z7CIyVhs43y3P1e66ucxbUQBPJGzW+sg
T0dNEy3kD+zxTtRuCuW0uNVB/+4M8oaY+6dqEtegIp8SwcRkLzWpIqxLTtSNL4ch
idaWHZUcQKTgduW2wML/
=ashh
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to