Package: json-c
Version: 0.10-1
Severity: serious
Tags: patch
User: [email protected]
Usertags: origin-ubuntu quantal ubuntu-patch
Hi Fabien,
Looking at the just uploaded json-c 0.10, it appears that upstream has a bug
in their Makefile which causes the json_object_iterator.h header to not be
installed in the package. Without this, the main json.h header does not
compile. Please check that reverse-dependencies of your library package are
still usable before uploading them to Debian!
In Ubuntu, the attached patch was applied for this issue. Changelog from
the Ubuntu upload:
* debian/patches/missing-headers.patch: Install json_object_iterator.h
header, needed by json.h.
* Build-depend on dh-autoreconf to regen Makefile.in for the above.
Thanks for considering the patch.
--
Steve Langasek Give me a lever long enough and a Free OS
Debian Developer to set it on, and I can move the world.
Ubuntu Developer http://www.debian.org/
[email protected] [email protected]
diff -Nru json-c-0.10/debian/control json-c-0.10/debian/control
--- json-c-0.10/debian/control 2012-08-17 09:43:43.000000000 -0700
+++ json-c-0.10/debian/control 2012-08-23 13:12:18.000000000 -0700
@@ -1,7 +1,7 @@
Source: json-c
Priority: extra
Maintainer: fabien boucher <[email protected]>
-Build-Depends: debhelper (>= 9)
+Build-Depends: debhelper (>= 9), dh-autoreconf
Standards-Version: 3.9.3.0
Section: libs
Homepage: http://oss.metaparadigm.com/json-c/
diff -Nru json-c-0.10/debian/patches/missing-headers.patch json-c-0.10/debian/patches/missing-headers.patch
--- json-c-0.10/debian/patches/missing-headers.patch 1969-12-31 16:00:00.000000000 -0800
+++ json-c-0.10/debian/patches/missing-headers.patch 2012-08-23 09:18:53.000000000 -0700
@@ -0,0 +1,18 @@
+Description: Install json_object_iterator.h header, needed by json.h
+ The upstream Makefile.am in json-c 0.10 missed installing
+ json_object_iterator.h, which is needed as a dependency. Adjust the
+ upstream rules to correct this.
+Author: Steve Langasek <[email protected]>
+
+Index: json-c-0.10/Makefile.am
+===================================================================
+--- json-c-0.10.orig/Makefile.am
++++ json-c-0.10/Makefile.am
+@@ -17,6 +17,7 @@
+ json_config.h \
+ json_inttypes.h \
+ json_object.h \
++ json_object_iterator.h \
+ json_object_private.h \
+ json_tokener.h \
+ json_util.h \
diff -Nru json-c-0.10/debian/patches/series json-c-0.10/debian/patches/series
--- json-c-0.10/debian/patches/series 2012-08-17 09:49:26.000000000 -0700
+++ json-c-0.10/debian/patches/series 2012-08-23 09:16:38.000000000 -0700
@@ -1 +1,2 @@
fix-format-string-in-test.patch
+missing-headers.patch
diff -Nru json-c-0.10/debian/rules json-c-0.10/debian/rules
--- json-c-0.10/debian/rules 2012-08-17 09:45:19.000000000 -0700
+++ json-c-0.10/debian/rules 2012-08-23 09:33:47.000000000 -0700
@@ -18,4 +18,4 @@
dh_strip --dbg-package=libjson0-dbg
%:
- dh $@
+ dh $@ --with autoreconf
