hi,

Carlos Alberto Lopez Perez wrote (21 Jul 2012 02:08:33 GMT) :
> This patches were already reviewed by upstream [1] and will be
> committed to the aircrack-ng repository ASAP.

Looks good! :)

There are minor differences (in changes to src/Makefile) with the
patch submitted upstream, though. Will these differences subsist, in
the form of a Debian-specific patch, once the patch submitted upstream
is part of a future upstream release?

>> Also, debian/copyright lacks information about src/sha1-git.c.

> because src/sha1-git.c is not part of the upstream tarball. This file is
> part of the patch debian/patches/011-add-support-for-gcrypt.diff

> Anyway I will be adding specific copyrights on debian/copyright for the
> patches of debian/patches

Great. Be the file part of the upstream tarball or added by a patch,
mentioning its copyright information in debian/copyright is not
optional, regardless of what must be put into the Files: field.

Cheers,
-- 
  intrigeri
  | GnuPG key @ https://gaffer.ptitcanardnoir.org/intrigeri/intrigeri.asc
  | OTR fingerprint @ https://gaffer.ptitcanardnoir.org/intrigeri/otr.asc


-- 
To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to