Hi again,

On Fri, Jul 20, 2012 at 01:07:36PM +0200, Evgeni Golov wrote:

> the trivial patch to debian/rules solves the issue quite good:
> So the only library without dbg symbols is libcsparse.so now.
> 
> Looking at the build-logs [1], it seems CFLAGS is just not passed into 
> CSparse/Lib.

The attached patch now also solves this issue. CSparse/Lib/Makefile was 
already patched, but did not include CFLAGS. This is done now.

As I am not sure how to test that libcsparse still works fine with -O3 
(it was previously built with -O only), I leave it as an excercise to 
the maintainer to apply this patch, test it an bridbe RT to accept it 
for wheezy.

Regards
Evgeni

-- 
Bruce Schneier can read and understand Perl programs.
diff -u suitesparse-3.4.0/debian/rules suitesparse-3.4.0/debian/rules
--- suitesparse-3.4.0/debian/rules
+++ suitesparse-3.4.0/debian/rules
@@ -12,7 +12,7 @@
 DEB_MAKE_BUILD_TARGET    := default
 DEB_COMPRESS_EXCLUDE     := .pdf
 
-CFLAGS=-fexceptions -Wall -O3
+CFLAGS=-fexceptions -Wall -O3 -g
 ifeq ($(DEB_HOST_ARCH_CPU),amd64)
  CFLAGS+=-m64
 endif
diff -u suitesparse-3.4.0/debian/changelog suitesparse-3.4.0/debian/changelog
--- suitesparse-3.4.0/debian/changelog
+++ suitesparse-3.4.0/debian/changelog
@@ -1,3 +1,11 @@
+suitesparse (1:3.4.0-2.1) UNRELEASED; urgency=low
+
+  * Non-maintainer upload.
+  * Add -g to CFLAGS.
+  * Honour CFLAGS in debian/patches/09-CSparse_Lib_Makefile.diff
+
+ -- Evgeni Golov <[email protected]>  Fri, 20 Jul 2012 12:33:50 +0200
+
 suitesparse (1:3.4.0-2) unstable; urgency=low
 
   * Maintainer changed to Debian Science
diff -u suitesparse-3.4.0/debian/patches/09-CSparse_Lib_Makefile.diff suitesparse-3.4.0/debian/patches/09-CSparse_Lib_Makefile.diff
--- suitesparse-3.4.0/debian/patches/09-CSparse_Lib_Makefile.diff
+++ suitesparse-3.4.0/debian/patches/09-CSparse_Lib_Makefile.diff
@@ -12,7 +12,7 @@
 +#CC = cc
 +#CFLAGS = -O -I../Include
 +
-+C = $(CC) -O -I../Include
++C = $(CC) $(CFLAGS) -I../Include
  
  AR = ar cr
  RANLIB = ranlib

Reply via email to