On 16.06.2012 23:54, Steve Langasek wrote: > On Sat, Jun 16, 2012 at 11:28:36PM +0200, Michael Biebl wrote: >> On 16.06.2012 22:18, Steve Langasek wrote: >>> tags 603405 patch >>> thanks > >>> The script needed for this is actually shipped in the current upstream >>> versions of gucharmap, so we just need to tweak it a litle bit for use with >>> the unicode-data package and run it at build time. The attached patch >>> addresses this. > >>> I'm uploading this patch as an NMU to DELAYED/2-days. > >> Thanks for the patch, Steve. > >> An odd thing I noticed, is that gen-guch-unicode-tables.pl is run twice: > >> configure/libgucharmap-2-90-dev:: >> cd gucharmap && ./gen-guch-unicode-tables.pl ... > >> It is run after ./configure, but apparently it is run a second time just >> before make install? > > I noticed this as well, I have no idea why this is happening.
Seems we have to use a stamp file, so I'll probably change that to
something like that:
post-patches:: debian/stamp-gen-unicode-tables
debian/stamp-gen-unicode-tables:
cd gucharmap && ./gen-guch-unicode-tables.pl $(UNICODE_DATA_VERSION)
/usr/share/unicode
touch debian/stamp-gen-unicode-tables
clean::
rm -f debian/stamp-gen-unicode-tables
>> It also seems to modify files (unicode-unihan.h) which are not properly
>> cleaned up and would end up in a debdiff if built twice in a row.
>
> They're cleaned up via debian/clean:
>
> diff -Nru gucharmap-3.4.1.1/debian/clean gucharmap-3.4.1.1/debian/clean
> --- gucharmap-3.4.1.1/debian/clean 1970-01-01 00:00:00.000000000 +0000
> +++ gucharmap-3.4.1.1/debian/clean 2012-06-16 19:34:08.000000000 +0000
> @@ -0,0 +1 @@
> +gucharmap/unicode-*.h
>
> Removing the file in the clean target via dh_clean will cause it to be
> automatically excluded from the diff.
>
Ah, I apparently missed that file. I was only looking at the clean::
rule in debian/rules.
Michael
--
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?
signature.asc
Description: OpenPGP digital signature
