On Wed, 11 Jan 2012 20:59:19 +0200, Ville Skyttä wrote:
> On 2012-01-11 15:41, David Paleino wrote:
> > On Wed, 11 Jan 2012 02:39:43 -0600, Jonathan Nieder wrote:
> >
> >> Probably something like
> >>
> >> local compscript=$(readlink -f "$BASH_SOURCE")
> >> [[ $compscript == */* ]] && compdir="${compscript%/*}/completions"
> >>
> >> in its place would do the trick.
>
> I think this is not appropriate upstream and should be reverted there.
>
> First, the readlink command does not exist everywhere.Since it's part of the "coreutils" package in Debian, I supposed it existed on all Linuxes. Surely I don't know about other Unices though (Solaris, *BSD, ...). If this is really true, then maybe we/I should find an alternative (considered that Debian also offers a BSD kernel). > Second, I don't think it's at all clear that if someone loads > bash_completion through a symlink, (s)he wouldn't want the completions > dir to be found relative to the symlink but rather whatever the symlink > points to. Do we really want to support that? Wasn't that line intended to facilitate upstream development? -- . ''`. Debian developer | http://wiki.debian.org/DavidPaleino : :' : Linuxer #334216 --|-- http://www.hanskalabs.net/ `. `'` GPG: 1392B174 ----|---- http://deb.li/dapal `- 2BAB C625 4E66 E7B8 450A C3E1 E6AA 9017 1392 B174
signature.asc
Description: PGP signature
