Bug#643386: ghex: FTBFS: ui.c:920:4: error: format not a string literal and no format arguments [-Werror=format-security]

[Bart Martens]

tags 643386 patch
stop



diff -ruN -x '*.png' -x '*.jpg' -x '*.ogg' -x '*_image_archive' ../orig/ghex-2.24.0/src/Makefile.in ./src/Makefile.in
--- ../orig/ghex-2.24.0/src/Makefile.in	2009-02-19 06:16:58.000000000 +0100
+++ ./src/Makefile.in	2011-10-04 03:59:16.000000000 +0200
@@ -77,7 +77,7 @@
 	gnome-print-font-picker.$(OBJEXT) factory.$(OBJEXT) \
 	hex-dialog.$(OBJEXT)
 ghex2_OBJECTS = $(am_ghex2_OBJECTS)
-ghex2_LDADD = $(LDADD)
+ghex2_LDADD = $(LDADD) -lm
 ghex2_DEPENDENCIES = $(am__DEPENDENCIES_1) $(am__DEPENDENCIES_1) \
 	libgtkhex.la
 DEFAULT_INCLUDES = -I.@am__isrc@ -I$(top_builddir)
diff -ruN -x '*.png' -x '*.jpg' -x '*.ogg' -x '*_image_archive' ../orig/ghex-2.24.0/src/ui.c ./src/ui.c
--- ../orig/ghex-2.24.0/src/ui.c	2008-08-13 05:58:20.000000000 +0200
+++ ./src/ui.c	2011-10-04 03:56:19.000000000 +0200
@@ -917,7 +917,7 @@
 			GTK_DIALOG_MODAL | GTK_DIALOG_DESTROY_WITH_PARENT,
 			GTK_MESSAGE_ERROR,
 			GTK_BUTTONS_OK,
-			msg);
+			"%s", msg);
 
 	gtk_dialog_set_default_response (GTK_DIALOG (error_dlg), GTK_RESPONSE_OK);
 	gtk_window_set_resizable (GTK_WINDOW (error_dlg), FALSE);
@@ -942,7 +942,7 @@
 			GTK_DIALOG_MODAL | GTK_DIALOG_DESTROY_WITH_PARENT,
 			GTK_MESSAGE_ERROR,
 			GTK_BUTTONS_OK,
-			real_msg);
+			"%s", real_msg);
 	g_free(real_msg);
 
 	gtk_dialog_set_default_response (GTK_DIALOG (info_dlg), GTK_RESPONSE_OK);