On Fri, Dec 17, 2010 at 02:57:39PM +0100, Alexander Reichle-Schmehl wrote: > * Alexander Reichle-Schmehl <toli...@debian.org> [101216 14:14]: > > > The only part missing would to make sure, snort-{mysql,pgsql} write into > > the new file instead of the old one, and purge the new file. But the > > main part taking care of this bug can already be reviewed if someone > > likes to do so ;) > > Attached is now a proposal to solve this bug. I must confess, that I > didn't had the change to do extensive testing (I did only upgrade tests, > no functionality tests), but I think I covered most scenarios. > > The only thing I can think of that might fail, is if a user modified his > /etc/snort/snort.conf himselve, and upgrades. In this case the db > configuration is splitt into a sepperate file, but the new "include" > line isn't added automatically, but the user will have the usual "new > configuration file, but you modified it, look at it" thing and hopefully > see the db releated chances. I'm not sure, if that problem can be solved > in a better way.
I see some issues with this bug. Some are minor (typos in the changelog and the text) but the most important thing is: there is no NEWS file so that users are forewarned of this (important) change. I would like to pick it up and carry it over from here... if I may. It seems you already did a NMU, so I might overwrite it with a new release (using your patch). Regards Javier
signature.asc
Description: Digital signature