Your message dated Mon, 18 Oct 2010 12:32:09 +0000
with message-id <[email protected]>
and subject line Bug#596681: fixed in cdrkit 9:1.1.11-1
has caused the Debian Bug report #596681,
regarding genisoimage: JTE image checksum incorrectly ASCII-encoded
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
596681: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=596681
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: genisoimage
Version: 9:1.1.10-1
Severity: serious
Justification: will break Debian CD building
Tags: patch
User: [email protected]
Usertags: origin-ubuntu ubuntu-patch maverick

I noticed recently that jigdo downloads of Ubuntu CDs were always
falsely claiming a corrupted checksum (that is, downloading with rsync
instead had no effect, and the actual checksum matched that shown in hex
in the .jigdo file).  I finally got round to investigating.

A .template file built with cdrkit 1.1.6 ended like this, for an md5sum
of 01f72c846845e4e19aec8a45912e5dda:

  002753c0  00 a0 06 2a 00 00 01 f7  2c 84 68 45 e4 e1 9a ec  |...*....,.hE....|
  002753d0  8a 45 91 2e 5d da 00 04  00 00 95 c1 00 00 00 00  |.E..]...........|

A .template file built with cdrkit 1.1.10 ended like this, for an md5sum
of e52a8467ec8a3a8584dd78f6f51bdd03:

  0026c5f0  04 00 00 00 05 00 48 3f  27 00 00 65 35 32 61 38  |......H?'..e52a8|
  0026c600  34 36 37 65 63 38 61 33  61 38 35 00 04 00 00 dc  |467ec8a3a85.....|
  0026c610  bc 00 00 00 00                                    |.....|

So the md5sum has been incorrectly ASCII-encoded, and thus truncated.
Not good!  I suggest the following patch (though I have only compiled it
so far, not actually tested it; that's in progress).

  * Use checksum_copy rather than checksum_hex when building the final jigdo
    template DESC entry.

--- cdrkit-1.1.10.orig/genisoimage/jte.c
+++ cdrkit-1.1.10/genisoimage/jte.c
@@ -753,7 +753,7 @@
 
     jimage.type = 5;
     write_le48(image_len, &jimage.imageLen[0]);
-    memcpy(jimage.imageMD5, checksum_hex(iso_context, CHECK_MD5), 
sizeof(jimage.imageMD5));
+    checksum_copy(jimage.imageMD5, iso_context, CHECK_MD5);
     write_le32(MIN_JIGDO_FILE_SIZE, &jimage.blockLen[0]);
     template_fwrite(&jimage, sizeof(jimage), 1, t_file);    
     template_fwrite(out_len, sizeof(out_len), 1, t_file);

Thanks,

-- 
Colin Watson                                       [[email protected]]



--- End Message ---
--- Begin Message ---
Source: cdrkit
Source-Version: 9:1.1.11-1

We believe that the bug you reported is fixed in the latest version of
cdrkit, which is due to be installed in the Debian FTP archive:

cdrkit-doc_1.1.11-1_all.deb
  to main/c/cdrkit/cdrkit-doc_1.1.11-1_all.deb
cdrkit_1.1.11-1.diff.gz
  to main/c/cdrkit/cdrkit_1.1.11-1.diff.gz
cdrkit_1.1.11-1.dsc
  to main/c/cdrkit/cdrkit_1.1.11-1.dsc
cdrkit_1.1.11.orig.tar.gz
  to main/c/cdrkit/cdrkit_1.1.11.orig.tar.gz
genisoimage_1.1.11-1_amd64.deb
  to main/c/cdrkit/genisoimage_1.1.11-1_amd64.deb
icedax_1.1.11-1_amd64.deb
  to main/c/cdrkit/icedax_1.1.11-1_amd64.deb
wodim_1.1.11-1_amd64.deb
  to main/c/cdrkit/wodim_1.1.11-1_amd64.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Steve McIntyre <[email protected]> (supplier of updated cdrkit package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Sun, 17 Oct 2010 23:33:48 +0100
Source: cdrkit
Binary: wodim genisoimage icedax cdrkit-doc
Architecture: source all amd64
Version: 9:1.1.11-1
Distribution: unstable
Urgency: low
Maintainer: Joerg Jaspert <[email protected]>
Changed-By: Steve McIntyre <[email protected]>
Description: 
 cdrkit-doc - Documentation for the cdrkit package suite
 genisoimage - Creates ISO-9660 CD-ROM filesystem images
 icedax     - Creates WAV files from audio CDs
 wodim      - command line CD/DVD writing tool
Closes: 513024 596681 596860
Changes: 
 cdrkit (9:1.1.11-1) unstable; urgency=low
 .
   * New upstream release.
     - genisoimage: Fix silly bug in MD5 output in template files.
       Closes: #596681
     - Update references to atterer.org (Closes: #596860)
     - Minor tweaks to the genisoimage.1 man page
   * Remove the old cdrecord/cdda2wav/mkisofs transitional packages.
     Closes: #513024
   * Updates for lintian warnings:
     - Add ${misc:Depends}
     - Fix build dependency on cmake to be less version specific
     - Change ordering of dh_ commands
     - Updated Standards-Version to 3.9.1
     - Refer to /usr/share/common-licenses/GPL-2 instead of
       /usr/share/common-licenses/GPL
     - Fix some typos/spelling mistakes in docs
     - Removed empty wodim maintainer scripts
Checksums-Sha1: 
 a833b14f8f690acee04518e6d3b16ef04358b7e1 1876 cdrkit_1.1.11-1.dsc
 3f7ddc06db0272942e1a4cd98c3c96462df77387 1445133 cdrkit_1.1.11.orig.tar.gz
 c545a9a954cc7cad8dab593b5e3c69739a9f40c1 27250 cdrkit_1.1.11-1.diff.gz
 c952477290b381595feb698889b7e5590b6cb817 159626 cdrkit-doc_1.1.11-1_all.deb
 f51c52912fd3eeec932da044b5e7c388d455aa6b 460234 wodim_1.1.11-1_amd64.deb
 f754393d1560df6fe98fff8d02c80c897e9c0dfe 194524 icedax_1.1.11-1_amd64.deb
 0dfe0f900a644c4c748ac39204a0727ea1e92b65 635126 genisoimage_1.1.11-1_amd64.deb
Checksums-Sha256: 
 f61bf101d23cccc4ae15e342da22dd0f4abd6bfbeb62a24dddf38685edce2f51 1876 
cdrkit_1.1.11-1.dsc
 d1c030756ecc182defee9fe885638c1785d35a2c2a297b4604c0e0dcc78e47da 1445133 
cdrkit_1.1.11.orig.tar.gz
 d884d8698b3e221f13564d77af61047955b71946ad0aa2ffd1290b5634c09c36 27250 
cdrkit_1.1.11-1.diff.gz
 fe28289772c3c284a5b4d814225c0364dc25dd0e3145c83cfe4f5434e3899ae8 159626 
cdrkit-doc_1.1.11-1_all.deb
 d740fa8708869f74c8582639f5df0036198b296f47c26cde7b8dfc95e73013cb 460234 
wodim_1.1.11-1_amd64.deb
 cef068c2d160623ce70a4fd469e45701fd35054c6a4e03bc5d9e02d60b418904 194524 
icedax_1.1.11-1_amd64.deb
 b8801b66d39750fb3a4da2cc2ed8c61e9a56de022ee940e4a8ad55a321de8667 635126 
genisoimage_1.1.11-1_amd64.deb
Files: 
 213e8d44fc654a60945dbd7fa69642a2 1876 otherosfs optional cdrkit_1.1.11-1.dsc
 efe08e2f3ca478486037b053acd512e9 1445133 otherosfs optional 
cdrkit_1.1.11.orig.tar.gz
 2660f2f82caf364a62baa31596ed9aa4 27250 otherosfs optional 
cdrkit_1.1.11-1.diff.gz
 384cad61fba149b29f0db4d231f8fb9a 159626 doc optional 
cdrkit-doc_1.1.11-1_all.deb
 84996eb65d1f6f1de87882772cf0e453 460234 otherosfs optional 
wodim_1.1.11-1_amd64.deb
 72861e2448696eb0e642acacff9284fc 194524 sound optional 
icedax_1.1.11-1_amd64.deb
 9db1d7ee65c24f56ddd1b15ce67b012c 635126 otherosfs optional 
genisoimage_1.1.11-1_amd64.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iQIcBAEBCAAGBQJMvDzTAAoJEFh5eVc0QmhOs6sP/A6N4FUArFRqNxVfxvlK156g
Sj30S7JP/188jnJItKHLbIlOG2CC2ontAyF5NI3hIQD2sfA7hmy4mukOmUiFYRBp
Fa6QggAd74tTGvoVrCk72qSSuPqdgkKXTGGJKICd8FtH+tvQGCNZ2+967pS/ghSK
WfeKMiyRWnRvnzhxf1voQMErZf36rcJhTNdodtjErmP+yqjHGJkrOJOuQGZ4C/hh
hCBWcyYwePrpITcuD0xmJHCgu4aJsnFi4SjPPCzLuE5YozPOETY70yHuCSzY9gY9
ml8Cj98jPSPEk+VZ1kg3NharSXmulY83NAjgwhB+wkr6saLaoD/lB4y6EejHyDJC
HBaK6rreJDrZ8nQezuihMqI0gfuBdTpy+Rf2Yb4eva6PtvcvD3X0fdRfHJNNl0cW
lpP0B3Kn8/4ddnPXmJPJ3oQye+pPY0NY1eqBOs8AQGR3DVrdC6hYdxlKbE4iCo5B
1tgMUXFCIdYaledswf6WloxITRXvwb8/AXF1KQ657RNo5VfWjHbUre1uszUin0S1
MZYaJ4PJlL177h6FqhyhXewGGR/CoFM0Xh1uDXrcRu7OmaqGdUxxa0vFmQFGEFBE
h/QaAfkljvSNjHhqlWIxzYh4Qt8N6vk0pnFn4kUkx8XGP15vqoa9Qj4hfB2IYF7s
sezK8iXL4GWG9I8XJBbO
=pQUi
-----END PGP SIGNATURE-----



--- End Message ---

Reply via email to