A few comments, while looking at your packages:

a/ you use *.install files for libunac1-dev and libunac1, but not for unaccent.
dh_install is recommended over dh_movefiles. Please covert unaccent.files, too.
b/ Please use libunac1 (= ${binary:Version}) instead of
libunac1 (= ${Source-Version})
c/ Please consider adding ${misc:Depends} to your binary packages, as you are
using debhelper.
d/ The build-depends on debconf | debconf-2.0 doesn't make sense to me, and the
changelog does not mention why it was added. I can only assume it was by
accident. You might consider removing it.

Lintian shows some more warnings:

W: unac source: changelog-should-mention-nmu
W: unac source: source-nmu-has-incorrect-version-number 1.8.0-4
W: unac source: debhelper-but-no-misc-depends libunac1
W: unac source: debhelper-but-no-misc-depends unaccent
W: unac source: debhelper-but-no-misc-depends libunac1-dev
W: unac source: substvar-source-version-is-deprecated libunac1-dev
W: unac source: ancient-libtool ltconfig
W: libunac1: debian-copyright-file-uses-obsolete-national-encoding at line 1
W: libunac1: copyright-refers-to-versionless-license-file
usr/share/common-licenses/GPL
W: libunac1: old-fsf-address-in-copyright-file
W: libunac1: copyright-without-copyright-notice
W: libunac1-dev: debian-copyright-file-uses-obsolete-national-encoding at line 1
W: libunac1-dev: copyright-refers-to-versionless-license-file
usr/share/common-licenses/GPL
W: libunac1-dev: old-fsf-address-in-copyright-file
W: libunac1-dev: copyright-without-copyright-notice
W: libunac1-dev: manpage-has-errors-from-man usr/share/man/man3/unac.3.gz 1:
warning: macro `''' not defined
W: unaccent: debian-copyright-file-uses-obsolete-national-encoding at line 1
W: unaccent: copyright-refers-to-versionless-license-file
usr/share/common-licenses/GPL
W: unaccent: old-fsf-address-in-copyright-file
W: unaccent: copyright-without-copyright-notice

e/ You use different email addresses / names in debian/control and
debian/changelog while it is preferrable to use the same, otherwise external
tools treat the upload as NMU.


Cheers,
Michael

-- 
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?

Attachment: signature.asc
Description: OpenPGP digital signature

Reply via email to