On Fri, 2010-05-07 at 16:42 -0600, dann frazier wrote: > Source: linux-2.6 > Version: 2.6.32-12 > Severity: serious > Tags: patch > > /usr/sbin/elilo didn't like the converted elilo.conf because it > doesn't support quoted strings, or spaces around '='.
Oops, when I read the code it looked like it was closely based on LILO (like many other bootloaders). Apparently it's not so close. > Instead of: > boot = "/dev/disk/by-uuid/9C73-E0C3" > it needs: > boot=/dev/disk/by-uuid/9C73-E0C3 > > The following patch fixes it, but it is pretty ugly. I would've > preferred to use the line that is commented out, but when I do I get > an extraneous newline both before and after the newly inserted line. > I assume this is due to how things are tokenized (I'm not enough of a > perl guy to grok it). [...] LILO doesn't care about whitespace in its configuration - new-lines, tabs and space are equivalent, except in comments. I added new-lines to ensure that the conversion comments-out only the tokens being replaced. I'll re-read the ELILO code to check exactly how its parser differs. Ben. -- Ben Hutchings Once a job is fouled up, anything done to improve it makes it worse.
signature.asc
Description: This is a digitally signed message part
