Bug#576570: libpod-xhtml-perl: FTBFS: t/Pod_Hyperlink_BounceURL.t fails

[gregor herrmann]

On Mon, 05 Apr 2010 21:07:03 +0300, Niko Tyni wrote:

> -<a class="pod_xhtml_bounce_url" 
> href="/apps/trampoline.rb?p=crontab(5)&amp;n=&amp;s=1">User Crontab</a> X</p>
> +<a class="pod_xhtml_bounce_url" 
> href="/apps/trampoline.rb?p=crontab%285%29&amp;n=&amp;s=1">User Crontab</a> 
> X</p>

> and as lib/Pod/Hyperlink/BounceURL.pm uses URI::Escape, the likely culprit is
> this liburi-perl upstream change (URI-1.53):
> 
>  Update URI::Escape for RFC 3986

Agreed, here's a part of the diff:

#v+
 This module provides functions to escape and unescape URI strings as
-defined by RFC 2396 (and updated by RFC 2732).
-A URI consists of a restricted set of characters,
-denoted as C<uric> in RFC 2396.  The restricted set of characters
-consists of digits, letters, and a few graphic symbols chosen from
-those common to most of the character encodings and input facilities
-available to Internet users:
+defined by RFC 3986.
 
-  "A" .. "Z", "a" .. "z", "0" .. "9",
-  ";", "/", "?", ":", "@", "&", "=", "+", "$", ",", "[", "]",   # reserved
-  "-", "_", ".", "!", "~", "*", "'", "(", ")"
+A URI consists of a restricted set of characters.  The restricted set
+of characters consists of digits, letters, and a few graphic symbols
+chosen from those common to most of the character encodings and input
+facilities available to Internet users.  They are made up of the
+"unreserved" and "reserved" character sets as defined in RFC 3986.
 
+   unreserved    = ALPHA / DIGIT / "-" / "." / "_" / "~"
+   reserved      = ":" / "/" / "?" / "#" / "[" / "]" / "@"
+                   "!" / "$" / "&" / "'" / "(" / ")"
+                 / "*" / "+" / "," / ";" / "="

[..]

 The default set of characters to be escaped is all those which are
-I<not> part of the C<uric> character class shown above as well as the
-reserved characters.  I.e. the default is:
+I<not> part of the C<unreserved> character class shown above as well
+as the reserved characters.  I.e. the default is:
 
-  "^A-Za-z0-9\-_.!~*'()"
+    "^A-Za-z0-9\-\._~"
#v-

which matches the brackets in the test.


Since the output seems ok, I guess changing the canned XHTML (and a
versioned dependency) is the way to fix this.

Committed to svn.


Cheers,
gregor

-- 
 .''`.   http://info.comodo.priv.at/ -- GPG key IDs: 0x8649AA06, 0x00F3CFE4
 : :' :  Debian GNU/Linux user, admin, & developer - http://www.debian.org/
 `. `'   Member of VIBE!AT & SPI, fellow of Free Software Foundation Europe
   `-    NP: James Taylor: You've Got A Friend

signature.asc
Description: Digital signature