Bug#571033: logrotate: Logrotate mis-parses config if log dir does not exist, and rotates wrong files

[Paul Martin]

On Tue, Mar 16, 2010 at 02:29:26PM +0700, Weerasak Chongnguluam wrote:

> from your patch parse571033.patch if *start == '\n' and
> (isblank(*start) && (*start)) never is true start dosen't incresed,
> cause infinite loop. Because isblank check only a space or a tab.

Puts on Brown Paper Bag.

Fixed patch attached.

-- 
Paul Martin <p...@debian.org>

Index: logrotate-3.7.8/config.c
===================================================================
--- logrotate-3.7.8.orig/config.c	2010-03-16 09:34:08.254007417 +0000
+++ logrotate-3.7.8/config.c	2010-03-16 09:42:32.434009264 +0000
@@ -574,9 +574,34 @@
 			    configFile, lineNum);
 		    return 1;
 		} else if (*start == '\n') {
-		    lineNum++;
+		    while (isspace(*start) && (*start)) {
+			if (*start == '\n')
+			    lineNum++;
+			start++;
+		    }
+		} else if (
+		    (strncmp(start, "postrotate", 10) == 0) ||
+		    (strncmp(start, "prerotate", 9) == 0) ||
+		    (strncmp(start, "firstrotate", 11) == 0) ||
+		    (strncmp(start, "lastrotate", 10) == 0)
+		    )
+		{
+		    while (*start) {
+			while ((*start != '\n') && (*start))
+			    start++;
+			while (isspace(*start) && (*start)) {
+			    if (*start == '\n')
+				lineNum++;
+			    start++;
+			}
+			if (strncmp(start, "endscript", 9) == 0) {
+			    start += 9;
+			    break;
+			}
+		    }
+		} else {
+		    start++;
 		}
-		start++;
 	    }
 	    start++;