Package: cone Version: 0.79-2 Severity: serious Tags: patch Justification: no longer builds from source
The patch sendmail_path.diff changes the timestamps of libmail/configure{,.in} resulting in autoconf's maintainer-mode kicking in and running aclocal and automake, grabbing the m4 macros for the new libtool and causing ./libtool to throw a big fuss about mismatched versions. This has not been an issue in Debian since autoconf and automake are not pulled into the Debian buildds, but in Ubuntu, they appear to be, as can be seen by the following build log: http://launchpadlibrarian.net/37421099/buildlog_ubuntu-lucid-i386.cone_0.79-2_FAILEDTOBUILD.txt.gz This issue can be resolved by replacing the sendmail_path.diff patch with an extra configure argument SENDMAIL=/usr/sbin/sendmail which should accomplish the same thing. In addition, the libtool build-dep can be safely removed, since it is not currently used at build time anyway. To prevent similar things from happening in the future, it would be good to get upstream to add AM_MAINTAINER_MODE to their configure.in files. CDBS will then be able to disable it with --disable-maintainer-mode which it already passes to the configure script. The attached patch contains Ubuntu specific changes, but please feel free to adapt it as you see fit. -- System Information: Debian Release: squeeze/sid APT prefers karmic-updates APT policy: (500, 'karmic-updates'), (500, 'karmic-security'), (500, 'karmic-proposed'), (500, 'karmic-backports'), (500, 'karmic') Architecture: amd64 (x86_64) Kernel: Linux 2.6.33-hyper1 (SMP w/2 CPU cores; PREEMPT) Locale: LANG=en_SG.UTF-8, LC_CTYPE=en_SG.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash
diff -Nru cone-0.79/debian/control cone-0.79/debian/control --- cone-0.79/debian/control 2009-11-28 19:12:58.000000000 +0800 +++ cone-0.79/debian/control 2010-02-27 05:01:02.000000000 +0800 @@ -3,7 +3,7 @@ Priority: optional Maintainer: Varun Hiremath <va...@debian.org> Build-Depends: cdbs, debhelper (>= 7.0), libncursesw5-dev, libxml2-dev, - libldap2-dev, libssl-dev, libfam-dev, aspell, procps, openssl, libtool + libldap2-dev, libssl-dev, libfam-dev, aspell, procps, openssl Standards-Version: 3.8.3 Homepage: http://www.courier-mta.org/cone/ Vcs-Svn: https://bollin.googlecode.com/svn/cone/ diff -Nru cone-0.79/debian/patches/sendmail_path.diff cone-0.79/debian/patches/sendmail_path.diff --- cone-0.79/debian/patches/sendmail_path.diff 2008-04-25 14:16:08.000000000 +0800 +++ cone-0.79/debian/patches/sendmail_path.diff 1970-01-01 07:30:00.000000000 +0730 @@ -1,26 +0,0 @@ -Index: cone-0.74/libmail/configure -=================================================================== ---- cone-0.74.orig/libmail/configure 2008-04-25 11:41:49.000000000 +0530 -+++ cone-0.74/libmail/configure 2008-04-25 11:41:58.000000000 +0530 -@@ -19397,7 +19397,7 @@ - done - IFS=$as_save_IFS - -- test -z "$ac_cv_path_SENDMAIL" && ac_cv_path_SENDMAIL="/usr/bin/sendmail" -+ test -z "$ac_cv_path_SENDMAIL" && ac_cv_path_SENDMAIL="/usr/sbin/sendmail" - ;; - esac - fi -Index: cone-0.74/libmail/configure.in -=================================================================== ---- cone-0.74.orig/libmail/configure.in 2008-04-25 11:42:23.000000000 +0530 -+++ cone-0.74/libmail/configure.in 2008-04-25 11:42:31.000000000 +0530 -@@ -23,7 +23,7 @@ - - LPATH="$PATH:/usr/local/bin:/usr/sbin:/sbin:/lib" - --AC_PATH_PROG(SENDMAIL, sendmail, /usr/bin/sendmail, $LPATH) -+AC_PATH_PROG(SENDMAIL, sendmail, /usr/sbin/sendmail, $LPATH) - - AC_DEFINE_UNQUOTED(SENDMAIL, "$SENDMAIL", - [ Local sendmail program ]) diff -Nru cone-0.79/debian/patches/series cone-0.79/debian/patches/series --- cone-0.79/debian/patches/series 2008-06-12 04:09:32.000000000 +0800 +++ cone-0.79/debian/patches/series 1970-01-01 07:30:00.000000000 +0730 @@ -1,2 +0,0 @@ -sendmail_path.diff - diff -Nru cone-0.79/debian/rules cone-0.79/debian/rules --- cone-0.79/debian/rules 2009-11-28 19:11:50.000000000 +0800 +++ cone-0.79/debian/rules 2010-02-27 05:01:31.000000000 +0800 @@ -3,6 +3,8 @@ include /usr/share/cdbs/1/class/autotools.mk include /usr/share/cdbs/1/rules/debhelper.mk +DEB_CONFIGURE_EXTRA_FLAGS = SENDMAIL=/usr/sbin/sendmail + install/cone:: #renaming config file mv $(DEB_DESTDIR)/etc/cone.dist $(DEB_DESTDIR)/etc/cone