Source: sfront Version: 0.94-2 Severity: serious Usertags: implicit-pointer-conversion Tags: patch
Our automated buildd log filter[1] detected a problem that is likely to cause your package to segfault on architectures where the size of a pointer is greater than the size of an integer, such as ia64 and amd64. Function `strcasestr' implicitly converted to pointer at sfmain.c:1150 This is often due to a missing function prototype definition. For more information, see [2]. Though it is guaranteed that this codepath will cause a segfault on certain architectures, it is not guaranteed that this codepath would ever be executed (e.g., if the returned pointer is never dereferenced). However, this bug does prevent the ia64 buildd from successfully building this package, resulting in a practical FTBFS issue and warranting the serious severity. [1] http://people.debian.org/~dannf/check-implicit-pointer-functions [2] http://wiki.debian.org/ImplicitPointerConversions
--- sfront-0.94.orig/src/tree.h 2009-12-29 12:44:35.000000000 -0700 +++ sfront-0.94/src/tree.h 2009-12-29 12:52:56.518696372 -0700 @@ -41,10 +41,11 @@ #define _SFRONT_TREE_H 1 #define IDSTRING "0.94 12/14/09" +#define _GNU_SOURCE /* strcasestr */ +#include <string.h> #include <stdio.h> #include <math.h> -#include <string.h> #include <ctype.h> #include <stdlib.h> #include <float.h>
