Your message dated Sun, 20 Dec 2009 15:36:15 +0000
with message-id <e1nmnpp-0002bu...@ries.debian.org>
and subject line Bug#551718: fixed in eboard 1.1.1-4.1
has caused the Debian Bug report #551718,
regarding eboard: FTBFS with latest eglibc and gcc 4.4
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
551718: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=551718
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: eboard
Version: 1.1.1-4
Severity: important
Tags: patch
Justification: fails to build from source
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu karmic ubuntu-patch

Hi,

eboard is FTBFS with the following compilation error in Ubuntu:
g++ -O2 -g -fsigned-char -D_REENTRANT -I/usr/include/gtk-2.0 
-I/usr/lib/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/cairo 
-I/usr/include/pango-1.0 -I/usr/include/pixman-1 -I/usr/include/freetype2 
-I/usr/include/directfb -I/usr/include/libpng12 -I/usr/include/glib-2.0 
-I/usr/lib/glib-2.0/include -c ntext.cc -o ntext.o
ntext.cc: In member function 'void NText::append(const char*, int, int)':
ntext.cc:247: error: invalid conversion from 'const char*' to 'char*'
make[1]: *** [ntext.o] Error 1
make[1]: Leaving directory `/build/buildd/eboard-1.1.1'
make: *** [build-stamp] Error 2

This is fixed with the attached patch.

Thanks,
Fabrice

*** /tmp/tmpmV1puW
In Ubuntu, we've applied the attached patch to achieve the following:

  * 95_ubuntu_gcc_4.4.dpatch: fix a "invalid conversion from 'const char*' to
    'char*'" compilation error in ntext.cc

We thought you might be interested in doing the same. 


-- System Information:
Debian Release: squeeze/sid
  APT prefers karmic-updates
  APT policy: (500, 'karmic-updates'), (500, 'karmic-security'), (500, 'karmic')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.28-15-generic (SMP w/2 CPU cores)
Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968)
Shell: /bin/sh linked to /bin/dash
diff -u eboard-1.1.1/debian/patches/00list eboard-1.1.1/debian/patches/00list
--- eboard-1.1.1/debian/patches/00list
+++ eboard-1.1.1/debian/patches/00list
@@ -7,0 +8 @@
+95_ubuntu_gcc_4.4.dpatch
only in patch2:
unchanged:
--- eboard-1.1.1.orig/debian/patches/95_ubuntu_gcc_4.4.dpatch
+++ eboard-1.1.1/debian/patches/95_ubuntu_gcc_4.4.dpatch
@@ -0,0 +1,50 @@
+#! /bin/sh /usr/share/dpatch/dpatch-run
+## 95_ubuntu_gcc_4.4.dpatch by Fabrice Coutadeur <fabric...@ubuntu.com>
+##
+## All lines beginning with `## DP:' are a description of the patch.
+## DP: Fix a compilation error due to invalid conversion from 'const char*' to
+## DP: 'char*'. This is achieved by copying the string before modifying it.
+
+...@dpatch@
+diff -urNad eboard-1.1.1~/ntext.cc eboard-1.1.1/ntext.cc
+--- eboard-1.1.1~/ntext.cc	2008-02-22 15:51:22.000000000 +0000
++++ eboard-1.1.1/ntext.cc	2009-10-20 04:35:42.000000000 +0000
+@@ -33,6 +33,7 @@
+ #include <gtk/gtkselection.h>
+ #include "ntext.h"
+ #include "global.h"
++#include <assert.h>
+ 
+ NLine::NLine() {
+   Text = NULL;
+@@ -238,23 +239,27 @@
+   int i;
+   NLine *nl;
+   char *p;
++  char *s;
+ 
+   if (len < 0) {
+     discardExcess();
+     return;
+   }
+ 
+-  p = strchr(text, '\n');
++  s = strdup(text);
++  assert(s !=  NULL);
++  p = strchr(s, '\n');
+   if (p!=NULL) {
+     *p = 0;
+-    i = strlen(text);
+-    nl = new NLine(text, color);
++    i = strlen(s);
++    nl = new NLine(s, color);
+     *p = '\n';
+     lines.push_back(nl);
+     formatLine(lines.size()-1);
+     append(&p[1], len-(i+1), color);
+     return;
+   }
++  free (s);
+ 
+   // if search for \n failed, this is a single line
+   nl = new NLine(text, color);

--- End Message ---
--- Begin Message ---
Source: eboard
Source-Version: 1.1.1-4.1

We believe that the bug you reported is fixed in the latest version of
eboard, which is due to be installed in the Debian FTP archive:

eboard_1.1.1-4.1.diff.gz
  to main/e/eboard/eboard_1.1.1-4.1.diff.gz
eboard_1.1.1-4.1.dsc
  to main/e/eboard/eboard_1.1.1-4.1.dsc
eboard_1.1.1-4.1_i386.deb
  to main/e/eboard/eboard_1.1.1-4.1_i386.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 551...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
David Paleino <da...@debian.org> (supplier of updated eboard package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Sun, 20 Dec 2009 14:44:06 +0100
Source: eboard
Binary: eboard
Architecture: source i386
Version: 1.1.1-4.1
Distribution: unstable
Urgency: low
Maintainer: Patrik Fimml <pat...@fimml.at>
Changed-By: David Paleino <da...@debian.org>
Description: 
 eboard     - GTK+ chessboard program
Closes: 551718
Changes: 
 eboard (1.1.1-4.1) unstable; urgency=low
 .
   * Non-maintainer upload.
   * debian/patches/95_ubuntu_gcc_4.4.dpatch added, fixes FTBFS "invalid
     conversion from 'const char*' to 'char*'", thanks to Fabrice
     Coutadeur from Ubuntu for the patch (Closes: #551718)
Checksums-Sha1: 
 21233ffa52d5cf331413c0a3c3ee266ef2ad3f0e 1033 eboard_1.1.1-4.1.dsc
 bce48ec2d4eb4e5817e45579a217e6e7f635d3ba 17247 eboard_1.1.1-4.1.diff.gz
 229749314c14d258710dc57722d49a41fe223c2a 552664 eboard_1.1.1-4.1_i386.deb
Checksums-Sha256: 
 a3faf21182c540aee7f92875d0c88fb9cbd9670bd2ffd823accdd5e592903520 1033 
eboard_1.1.1-4.1.dsc
 9be0e7fb3cc59edec3fd5c0c2c562eb56fea36afd3c23ac21c1f3ada6acf3617 17247 
eboard_1.1.1-4.1.diff.gz
 4ede8ed849a7b76e44fedfe3e5db397b80d34e3029ad492400536d2175f698bf 552664 
eboard_1.1.1-4.1_i386.deb
Files: 
 5efe511823f89015e56a617fa8301169 1033 games optional eboard_1.1.1-4.1.dsc
 1dfa2f28e29e1e186875f548a9c7baa9 17247 games optional eboard_1.1.1-4.1.diff.gz
 48aa11fc40e01dec005d181661c8c930 552664 games optional 
eboard_1.1.1-4.1_i386.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iEYEARECAAYFAksuK5MACgkQ5qqQFxOSsXRynQCbBM86tPcf0kmE52CRQYn69EtC
7WQAoMu2iDVa7DTmeYSCiVoOGMHv7byr
=SlHf
-----END PGP SIGNATURE-----



--- End Message ---

Reply via email to