tags 521938 + patch
thanks

The attached patch renames the signal structure, and thereby, fixes
the bug. I shall prepare an NMU, if you desire.

The original package and diff.gz, however, are not clean. For example:

[ku...@bluemoon /tmp/gtkdialog] lintian -I gtkdialog_0.7.20-4.dsc 
I: gtkdialog source: dpatch-missing-description 01_bashism.dpatch
E: gtkdialog source: patch-modifying-debian-files 01_bashism.dpatch 
gtkdialog-0.7.20/debian/patches/01_bashism.dpatch
I: gtkdialog source: dpatch-missing-description 02_documentation_paths.dpatch
E: gtkdialog source: patch-modifying-debian-files 02_documentation_paths.dpatch 
gtkdialog-0.7.20/debian/patches/02_documentation_paths.dpatch
I: gtkdialog source: dpatch-missing-description 03_stdin.dpatch
W: gtkdialog source: patch-system-but-no-source-readme
W: gtkdialog source: patch-system-but-direct-changes-in-diff config.guess and 4 
more

The modifying debian files part is bogus, as I can see. However, it is
true that you have some leftovers in the .diff.gz:

[ku...@bluemoon /tmp/gtkdialog] diffstat gtkdialog_0.7.20-4.diff.gz 
 config.guess                                 | 1500 +++++++++++++++++++++++++
 config.sub                                   | 1616 +++++++++++++++++++++++++++
 [snip debian part]
 examples/05.01-progress_bar_closewindow      |    2 
 examples/05.02-progress_bar_test             |    2 
 examples/09.12-tree_one_column               |    2 

HTH, Thanks!

Kumar
-- 
Kumar Appaiah
#! /bin/sh /usr/share/dpatch/dpatch-run
## 04_rename_signal_struct.dpatch by  <[email protected]>
##
## All lines beginning with `## DP:' are a description of the patch.
## DP: Rename instances of signal to signal_struct to prevent FTBFS
## DP: (Debian bug no. 521938)

@DPATCH@
diff -urNad gtkdialog-0.7.20~/src/glade_support.c 
gtkdialog-0.7.20/src/glade_support.c
--- gtkdialog-0.7.20~/src/glade_support.c       2007-03-16 09:25:49.000000000 
-0500
+++ gtkdialog-0.7.20/src/glade_support.c        2009-09-20 21:43:29.000000000 
-0500
@@ -40,7 +40,7 @@
 typedef struct signal {
        gchar     *name;
        GCallback callback;
-} signal;
+} signal_struct;
 
 /*
 ** Signal handler callbascks.
@@ -206,7 +206,7 @@
 static gboolean
 find_and_connect_handler(
                GtkWidget *widget,
-               signal *signals,
+               signal_struct *signals,
                const gchar *signal_name,
                const gchar *handler_name)
 {
@@ -288,7 +288,7 @@
                gpointer user_data)
 {
        gint n;
-       signal entry_signals[] = {
+       signal_struct entry_signals[] = {
                { "activate",           (GCallback)on_any_entry_almost_any },
                { "backspace",          (GCallback)on_any_entry_almost_any },
                { "copy-clipboard",     (GCallback)on_any_entry_almost_any },
@@ -319,7 +319,7 @@
                gpointer user_data)
 {
        variable *var;
-       signal widget_signals[] = {
+       signal_struct widget_signals[] = {
                { "accel-closures-changed",    
(GCallback)on_any_widget_almost_any },
                { "composited-changed",        
(GCallback)on_any_widget_almost_any },
                { "grab-focus",                
(GCallback)on_any_widget_almost_any },

Attachment: signature.asc
Description: Digital signature

Reply via email to