There seems to be two problems with -no-shutdown in kvm-85:
1) in qemu mode (-no-kvm), we first hit
if (shutdown_requested) {
ret = EXCP_INTERRUPT;
if (no_shutdown) {
vm_stop(0);
no_shutdown = 0;
}
else
break;
}
while vm_running is true. This resets no_shutdown, but does *not* reset
shutdown_requested. The vm_stop(0) makes us hit the
} else {
if (shutdown_requested) {
ret = EXCP_INTERRUPT;
break;
}
timeout = 5000;
}
on next loop iteration and the loop exits. The obvious fix is to reset
shutdown_requested on test, by e.g. replacing it with
qemu_shutdown_requested()
2) with kvm enabled, there doesn't seem to be any handling of
-no-shutdown at all. the kvm_main_loop will break unconditionally if
qemu_shutdown_requested() is true:
while (1) {
main_loop_wait(1000);
if (qemu_shutdown_requested())
break;
I don't provide any patches for these problems, as the code is
refactored in newer KVM versions and both problems most likely are gone
there. Fixing kvm-85 seems futile. Please upgrade kvm in unstable to the
latest and greatest instead (qemu-kvm-0.11.0-rc1 or newer). It has this
in it's kvm_main_loop():
if (qemu_shutdown_requested()) {
if (qemu_no_shutdown()) {
vm_stop(0);
} else
break;
}
Bjørn
--
To UNSUBSCRIBE, email to [email protected]
with a subject of "unsubscribe". Trouble? Contact [email protected]
