Hello!

I had a really quick look and there seems to be several issues.

Next after parsing the command line options, the server forks and kills
off the parent (in wzdftpd/wzd_main.c line 402). This leaves no room for
returning a proper error/exit code if something in the startup process
fails.

The server doesn't seem to have any support for writing a pidfile on
it's own. Instead the start-stop-daemon feature is used in the init.d
script. There seems to be several issues here:

First the path to the pidfile is not consistently used
(/var/run/$NAME.pid v. /var/run/$NAME/$NAME.pid).

The second issue being, can start-stop-daemon really write a useful
pidfile when the process it starts will terminate right away? The
pidfile should contain the child pid, not the parent pid, since the
child is the actual server here.

The third issue is that this setup relies on debians default
configuration of a /var/run on persistant storage, since
the /var/run/wzdftpd/ directory is (only) created in the postinst
instead of the init.d script. Ubuntu has switched the default and as
suspected that bug has been fixed there. You can get the patch from
http://patches.ubuntu.com/w/wzdftpd/wzdftpd_0.8.3-5.1ubuntu1.patch which
will also fix up a dependency issue (postgresql vs postgresql-client).

Popcon tells me there are only 28 people with this package installed and
3 recently using it. Maybe we should consider removal?

-- 
Regards,
Andreas Henriksson



-- 
To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to