Package: gcstar
tag 510685 + patch
thanks

I compared the current Debian tarball with the upstream tarball for
1.4.3 that reportedly contains the fix and isolated the problem down to
lib/gcstar/GCPlugins.pm. A single line change is made in the relevant
portion of the module in 1.4.3 and backporting this change to 1.3.2
fixes the issue on my system.

(I was able to reproduce the bug and this patch fixes the bug.)

+diff -urNad gcstar-1.3.2~/lib/gcstar/GCPlugins.pm
gcstar-1.3.2/lib/gcstar/GCPlugins.pm +---
gcstar-1.3.2~/lib/gcstar/GCPlugins.pm      2008-01-25
18:26:44.000000000 +0000 ++++
gcstar-1.3.2/lib/gcstar/GCPlugins.pm       2009-01-04
15:44:12.000000000 +0000 +@@ -139,6 +139,7 @@
+                     $plugin->{title} = $info->{query};
+                     $plugin->{searchField} = $info->{field};
+                     $plugin->load;
++                    local $Storable::forgive_me = 1;
+                     store_fd $plugin, $self->{data};
+                 }
+                 elsif ($info->{type} ne 'exit')

Full nmudiff attached.

-- 


Neil Williams
=============
http://www.data-freedom.org/
http://www.linux.codehelp.co.uk/
http://e-mail.is-not-s.ms/

diff -u gcstar-1.3.2/debian/changelog gcstar-1.3.2/debian/changelog
--- gcstar-1.3.2/debian/changelog
+++ gcstar-1.3.2/debian/changelog
@@ -1,3 +1,12 @@
+gcstar (1.3.2-1.1) unstable; urgency=low
+
+  * Non-maintainer upload.
+  * Backport Storage:::forgive_me change from new upstream version
+    to prevent Gcstar freeze when trying to retrieve data from a
+    website (Closes: #510685)
+
+ -- Neil Williams <[email protected]>  Sun, 04 Jan 2009 15:44:40 +0000
+
 gcstar (1.3.2-1) unstable; urgency=low
 
   * New upstream version
only in patch2:
unchanged:
--- gcstar-1.3.2.orig/debian/patches/10-fix-storable-crash.dpatch
+++ gcstar-1.3.2/debian/patches/10-fix-storable-crash.dpatch
@@ -0,0 +1,18 @@
+#! /bin/sh /usr/share/dpatch/dpatch-run
+## 10-fix-storable-crash.dpatch by Neil Williams <[email protected]>
+##
+## All lines beginning with `## DP:' are a description of the patch.
+## DP: No description.
+
+...@dpatch@
+diff -urNad gcstar-1.3.2~/lib/gcstar/GCPlugins.pm gcstar-1.3.2/lib/gcstar/GCPlugins.pm
+--- gcstar-1.3.2~/lib/gcstar/GCPlugins.pm	2008-01-25 18:26:44.000000000 +0000
++++ gcstar-1.3.2/lib/gcstar/GCPlugins.pm	2009-01-04 15:44:12.000000000 +0000
+@@ -139,6 +139,7 @@
+                     $plugin->{title} = $info->{query};
+                     $plugin->{searchField} = $info->{field};
+                     $plugin->load;
++                    local $Storable::forgive_me = 1;
+                     store_fd $plugin, $self->{data};
+                 }
+                 elsif ($info->{type} ne 'exit')

Attachment: pgp3PxxbfRsFX.pgp
Description: PGP signature

Reply via email to