Am 15.08.2008 14:42, Andreas Metzler schrieb:
On 2008-08-15 Clint Adams <[EMAIL PROTECTED]> wrote:

is there actually a reason for using the PID and for limiting the
non-pid part to [[A-Za-z]?

Why not
--------bugs included-----
--- mktemp-1.5.orig/priv_mktemp.c
+++ mktemp-1.5/priv_mktemp.c
@@ -81,25 +81,20 @@
        register char *start, *trv;
        struct stat sbuf;
        int pid, rval;
-       char *alphabet = "ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz";
+       char *alphabet = 
"ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789+-=%#_";

yes, but I would avoid the special chars as a component of filenames. You don't know what existing scripts will do with filenames like that. (however e.g. "_" might be safe under every circumstances, but it doesn't pay you that much here)


+               pid = (get_random() & 0xffff) % (26+26+10+6);

here, too




Cheers,
        Dirk



--
Dirk Wetter @ Dr. Wetter IT-Consulting          http://drwetter.org
Beratung IT-Sicherheit + Open Source
Key fingerprint = 2AD6 BE0F 9863 C82D 21B3  64E5 C967 34D8 11B7 C62F

-
Found core file older than 7 days: /usr/share/man/man5/core.5.gz




--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to