Your message dated Sat, 02 Aug 2008 14:02:03 +0000
with message-id <[EMAIL PROTECTED]>
and subject line Bug#493184: fixed in aufs 0+20080719-2
has caused the Debian Bug report #493184,
regarding aufs: Deadlocks in the rename() call.
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [EMAIL PROTECTED]
immediately.)
--
493184: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=493184
Debian Bug Tracking System
Contact [EMAIL PROTECTED] with problems
--- Begin Message ---
Package: aufs
Version: 0+20080719-1
Severity: serious
Tags: patch
Hi jak,
as you probably already know, there is a quite inconvenient bug in
sid+lenny's aufs, which is blocking renames, caused by deadlocks. That
means that one can't update the apt cache through apt-get/aptitude, at
the very least (it's not like rename() is something very rare anyway),
which IMHO makes it unfit for a stable release.
For more details, initial upstream bugreport:
http://article.gmane.org/gmane.linux.file-systems.aufs.user/1270
The patch as provided by upstream:
http://article.gmane.org/gmane.linux.file-systems.aufs.user/1291
The thread contains various confirmations that the patch does its job
and fixes the deadlocks. I personally tested it against a custom
snapshot I prepared: 20080714 (I didn't know 20080719 would follow some
days later, and I was checking whether the bug got fixed in the
meanwhile), but also with 0+20080719-1, against which I attach a
debdiff, so that you can eventually merge the patch quickly.
I kept the patch as is, only adapting the patch level. Feel free to
drop/adapt attribution lines in the patch/the changelog, nothing fancy
in preparing an upload. More precisely: I needed to do so to prepare
some (better-working) LiveCD images.
Cheers,
--
Cyril Brulebois
diff -u aufs-0+20080719/debian/changelog aufs-0+20080719/debian/changelog
--- aufs-0+20080719/debian/changelog
+++ aufs-0+20080719/debian/changelog
@@ -1,3 +1,11 @@
+aufs (0+20080719-2) unstable; urgency=low
+
+ * debian/patches/10_fix_deadlocks_in_rename.dpatch: Backport a fix for
+ blocking rename calls, caused by deadlocks, which led to hanging
+ package managers when trying to update the APT cache (Closes: #N).
+
+ -- Cyril Brulebois <[EMAIL PROTECTED]> Fri, 01 Aug 2008 04:07:49 +0000
+
aufs (0+20080719-1) unstable; urgency=low
* New upstream snapshot, fixing many bugs
diff -u aufs-0+20080719/debian/patches/00list aufs-0+20080719/debian/patches/00list
--- aufs-0+20080719/debian/patches/00list
+++ aufs-0+20080719/debian/patches/00list
@@ -8,0 +9 @@
+10_fix_deadlocks_in_rename.dpatch
only in patch2:
unchanged:
--- aufs-0+20080719.orig/debian/patches/10_fix_deadlocks_in_rename.dpatch
+++ aufs-0+20080719/debian/patches/10_fix_deadlocks_in_rename.dpatch
@@ -0,0 +1,56 @@
+#! /bin/sh /usr/share/dpatch/dpatch-run
+## 10_fix_deadlocks_in_rename.dpatch by Cyril Brulebois <[EMAIL PROTECTED]>
+##
+## DP: Fix deadlocks as detected by running aptitude update.
+
[EMAIL PROTECTED]@
+Index: fs/aufs/cpup.c
+===================================================================
+RCS file: /cvsroot/aufs/aufs/fs/aufs/cpup.c,v
+retrieving revision 1.67
+diff -u -p -r1.67 cpup.c
+--- a/fs/aufs/cpup.c 21 Jul 2008 02:51:28 -0000 1.67
++++ b/fs/aufs/cpup.c 24 Jul 2008 04:01:23 -0000
+@@ -1004,7 +1004,7 @@ int au_cp_dirs(struct dentry *dentry, au
+ h_parent = au_h_dptr(parent, bdst);
+ } while (!h_parent);
+
+- if (d != real_parent)
++ if (d != real_parent && d != locked)
+ di_write_lock_child3(d);
+
+ /* somebody else might create while we were sleeping */
+@@ -1041,7 +1041,7 @@ int au_cp_dirs(struct dentry *dentry, au
+ di_read_unlock(parent, AuLock_IR);
+ }
+
+- if (d != real_parent)
++ if (d != real_parent && d != locked)
+ di_write_unlock(d);
+ if (unlikely(err))
+ break;
+Index: fs/aufs25/cpup.c
+===================================================================
+RCS file: /cvsroot/aufs/aufs/fs/aufs25/cpup.c,v
+retrieving revision 1.11
+diff -u -p -r1.11 cpup.c
+--- a/fs/aufs25/cpup.c 21 Jul 2008 02:53:36 -0000 1.11
++++ b/fs/aufs25/cpup.c 24 Jul 2008 04:01:23 -0000
+@@ -998,7 +998,7 @@ int au_cp_dirs(struct dentry *dentry, au
+ h_parent = au_h_dptr(parent, bdst);
+ } while (!h_parent);
+
+- if (d != real_parent)
++ if (d != real_parent && d != locked)
+ di_write_lock_child3(d);
+
+ /* somebody else might create while we were sleeping */
+@@ -1036,7 +1036,7 @@ int au_cp_dirs(struct dentry *dentry, au
+ di_read_unlock(parent, AuLock_IR);
+ }
+
+- if (d != real_parent)
++ if (d != real_parent && d != locked)
+ di_write_unlock(d);
+ if (unlikely(err))
+ break;
--- End Message ---
--- Begin Message ---
Source: aufs
Source-Version: 0+20080719-2
We believe that the bug you reported is fixed in the latest version of
aufs, which is due to be installed in the Debian FTP archive:
aufs-source_0+20080719-2_all.deb
to pool/main/a/aufs/aufs-source_0+20080719-2_all.deb
aufs-tools_0+20080719-2_amd64.deb
to pool/main/a/aufs/aufs-tools_0+20080719-2_amd64.deb
aufs_0+20080719-2.diff.gz
to pool/main/a/aufs/aufs_0+20080719-2.diff.gz
aufs_0+20080719-2.dsc
to pool/main/a/aufs/aufs_0+20080719-2.dsc
linux-patch-aufs_0+20080719-2_all.deb
to pool/main/a/aufs/linux-patch-aufs_0+20080719-2_all.deb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [EMAIL PROTECTED],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Julian Andres Klode <[EMAIL PROTECTED]> (supplier of updated aufs package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [EMAIL PROTECTED])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.8
Date: Sat, 02 Aug 2008 15:21:20 +0200
Source: aufs
Binary: aufs-tools aufs-source linux-patch-aufs
Architecture: source all amd64
Version: 0+20080719-2
Distribution: unstable
Urgency: medium
Maintainer: Julian Andres Klode <[EMAIL PROTECTED]>
Changed-By: Julian Andres Klode <[EMAIL PROTECTED]>
Description:
aufs-source - Source for the aufs driver
aufs-tools - Tools to manage aufs filesystems
linux-patch-aufs - Kernel patches for aufs
Closes: 493184
Changes:
aufs (0+20080719-2) unstable; urgency=medium
.
[ Cyril Brulebois ]
* debian/patches/10_fix_deadlocks_in_rename.dpatch: Backport a fix for
blocking rename calls, caused by deadlocks, which led to hanging
package managers when trying to update the APT cache (Closes: #493184).
Checksums-Sha1:
78f2b1389a73fe1963c7285e9b439e943d280f76 1101 aufs_0+20080719-2.dsc
2900b88e52e06b96129d9adf29cfb787f2941271 15094 aufs_0+20080719-2.diff.gz
be0b7ee83fa384261b5c26c8bdcbcb1022e93c6e 41948
linux-patch-aufs_0+20080719-2_all.deb
283f5b8cc13c81d454d3017a26ce76bd92ec85dc 224366
aufs-source_0+20080719-2_all.deb
94743090421fc525a420bbd20a40a12908a6f8e4 122076
aufs-tools_0+20080719-2_amd64.deb
Checksums-Sha256:
5b2d3206038b66cf8adc33516e5b357b29308cd0d2fcda3a89d54618663f9b12 1101
aufs_0+20080719-2.dsc
f93a6107239e5b6020af1ec32b98403e9db47b13f76d3df0d42a579348601895 15094
aufs_0+20080719-2.diff.gz
b4ba81e531cb12eae59911f468f71f156f3d2ccb0dea755045b00e5474dd16c6 41948
linux-patch-aufs_0+20080719-2_all.deb
ad636df247f31e61f29eb70ea73963e08682276bac6b795ff76cd7eb17474a5b 224366
aufs-source_0+20080719-2_all.deb
dbcfdaacb9382af6b2a4d0e8d0c8b6603be25a11f5740dfd0bb0aeccd7cba154 122076
aufs-tools_0+20080719-2_amd64.deb
Files:
878ad13c22e3eabec99cf91e5f7264ec 1101 misc optional aufs_0+20080719-2.dsc
a4993c5cff694940cb631439101adc11 15094 misc optional aufs_0+20080719-2.diff.gz
b1241ac71c7d92be0f40debfef6e7010 41948 misc optional
linux-patch-aufs_0+20080719-2_all.deb
922a39cffe3a8867d7dd7e953c986b5b 224366 misc optional
aufs-source_0+20080719-2_all.deb
609c9035d156eda4ba9ac17edeae1e13 122076 misc optional
aufs-tools_0+20080719-2_amd64.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
iEYEARECAAYFAkiUZGwACgkQrCpf/gCCPsLo6gCgiuMSya5F+wUTcZoqBecsRLed
+XEAoLG+IVNV1PR5Un0aKjNyioplAEKR
=pd35
-----END PGP SIGNATURE-----
--- End Message ---
