Package: gwget2
Version: 0.95-1
Severity: serious
Tags: patch

gwget2 is missing an include which results in a return pointer being
implicitly converted to an int.  On some systems such as ia64 this will
result in a segfault if this return pointer is accessed.

Filing as serious, because this also fixes a FTBFS problem I ran into
when testing my build in pbuilder.  This is fixed by the additional
build-dep in this patch.

I'm sure a better fix is to make configure somehow add
-I/usr/include/gnome-vfs-module-2.0 to GNOME_CFLAGS and just
#include <libgnomevfs/gnome-vfs-mime.h>, but I don't know how to do
that :(

diff -urN gwget2-0.95.orig/debian/control gwget2-0.95/debian/control
--- gwget2-0.95.orig/debian/control     2005-05-24 21:26:16.000000000 -0600
+++ gwget2-0.95/debian/control  2005-05-24 21:02:48.000000000 -0600
@@ -2,7 +2,7 @@
 Section: gnome
 Priority: optional
 Maintainer: David Moreno Garza <[EMAIL PROTECTED]>
-Build-Depends: debhelper (>> 4.0.0), pkg-config, libgnomeui-dev, 
libgtk2.0-dev, libglade2-dev, libxml-parser-perl, libgcrypt11-dev
+Build-Depends: debhelper (>> 4.0.0), pkg-config, libgnomeui-dev, 
libgtk2.0-dev, libglade2-dev, libxml-parser-perl, libgcrypt11-dev, 
libgnomevfs2-dev
 Standards-Version: 3.6.1.1
 
 Package: gwget
diff -urN gwget2-0.95.orig/src/main_window_cb.c gwget2-0.95/src/main_window_cb.c
--- gwget2-0.95.orig/src/main_window_cb.c       2005-05-08 12:15:25.000000000 
-0600
+++ gwget2-0.95/src/main_window_cb.c    2005-05-24 21:19:51.000000000 -0600
@@ -23,6 +23,7 @@
 #include <libgnome/gnome-program.h>
 #include <libgnome/gnome-init.h>
 #include <libgnomevfs/gnome-vfs.h>
+#include <gnome-vfs-module-2.0/libgnomevfs/gnome-vfs-mime.h>
 #include "main_window.h"
 #include "main_window_cb.h"
 #include "new_window.h"

-- 
dann frazier <[EMAIL PROTECTED]>
--- Begin Message ---
Function `gnome_vfs_mime_type_from_name' implicitly converted to pointer at 
main_window_cb.c:232

--- End Message ---

Reply via email to