Hi Bernd,
Thanks once again for the patch... I decided to stick to pycentral for
now, so I adopted just a part of your modifications. Here are the
relevant changelog entries:
* Applied changes submitted by Bernd Zeimetz (thanks Bernd):
- Removed obsolete Build-Depends-Indep on help2man, python-dev
- Explicit removal of *.pyc files compiled during build
- Invoke 'python setup.py clean' in clean target, which required also
to move python into Build-Depends
(need to check what the heck with formatting) ;-)
tentative package is at
http://itanix.rutgers.edu/rumba/dists/sid/perspect/binary-all/net/fail2ban_0.8.0-2~pre2_all.deb
http://itanix.rutgers.edu/rumba/dists/sid/perspect/source/net/fail2ban_0.8.0-2~pre2.dsc
if no objections and further recommendations, I would like to upload it to
debian today/tomorrow.
Thanks once again and Cheers
On Mon, 07 May 2007, Bernd Zeimetz wrote:
> Heya,
> I've attached my patch with a changelog entry which should listen all
> changes I've done. And I hope I didn't add any new bugs - the package
> works fine here, though.
> While working on the fix, I run into the following issue which should be
> fixed in my opinion:
> Adding the sys.path in the fail-* scripts is a bad bad hack imho - it'll
> also mean you have to change the path with every python version - that's
> not really what you want. But that's more a problem of upstream than
> yours, but I think you want to poke upstream to change it.
> Upstream should move the module subdirectories into one namespace and
> import from there. It would look this way:
> The directory structure:
> .../fail2ban/__init__.py (may be empty, that's fine)
> .../fail2ban/server/........
> .../fail2ban/common/........
> .../fail2ban/client/........
> and then you do NOT
> from server.foo import bar
> but instead you do
> from fail2ban.server.foo import bar
> This will make it portable and will not need this very hackish sys.path
> change anymore. I didn't have the time to find all import and patch
> them, so I've decided to use the sys.path thing again, as this will work
> until you want to move to python2.5 - and that should be enough time to
> bring the modules in a more python like form.
> If I can help you with anything, please let me know.
> Cheers,
> Bernd
--
Yaroslav Halchenko
Research Assistant, Psychology Department, Rutgers-Newark
Student Ph.D. @ CS Dept. NJIT
Office: (973) 353-5440x263 | FWD: 82823 | Fax: (973) 353-1171
101 Warren Str, Smith Hall, Rm 4-105, Newark NJ 07102
WWW: http://www.linkedin.com/in/yarik
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
