Package: fbdesk
Version: 1.4.1-9
Severity: important
Tags: patch
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Dear Maintainer,
The LDFLAGS (hardening) flags are missing, including
- -Wl,--as-needed, because the patch
30-link-fix--non-usued-library--ICE-SM.patch removes LDFLAGS from
the build. Removing the patch fixes the issue.
The following patch simplifies debian/rules a little. CXXFLAGS
also contains the hardening flags used in CFLAGS:
diff -Nru fbdesk-1.4.1/debian/rules fbdesk-1.4.1/debian/rules
--- fbdesk-1.4.1/debian/rules 2012-03-05 08:36:00.000000000 +0100
+++ fbdesk-1.4.1/debian/rules 2012-03-06 18:03:42.000000000 +0100
@@ -3,8 +3,8 @@
PACKAGE = fbdesk
PKGDIR = $(shell pwd)/debian/$(PACKAGE)
-export DEB_CFLAGS_MAINT_APPEND = -Wall -pedantic -ffunction-sections
-export DEB_LDFLAGS_MAINT_APPEND = -Wl,--as-needed
+export DEB_CXXFLAGS_MAINT_APPEND = -Wall -pedantic -ffunction-sections
+export DEB_LDFLAGS_MAINT_APPEND = -Wl,--as-needed
man:
$(MAKE) -C debian -f pod2man.mk \
@@ -13,7 +13,7 @@
makeman
override_dh_auto_configure: man
- CXXFLAGS="$(CFLAGS)" ./configure --prefix=/usr
+ ./configure --prefix=/usr
%:
dh $@
To check if all flags were correctly enabled you can use
`hardening-check` from the hardening-includes package:
$ hardening-check /usr/bin/fbdesk
/usr/bin/fbdesk:
Position Independent Executable: no, normal executable!
Stack protected: yes
Fortify Source functions: yes (some protected functions found)
Read-only relocations: yes
Immediate binding: no not found!
(Position Independent Executable and Immediate binding is not
enabled by default.)
Use find -type f \( -executable -o -name \*.so\* \) -exec
hardening-check {} + on the build result to check all files.
Regards,
Simon
[1]: https://wiki.debian.org/ReleaseGoals/SecurityHardeningBuildFlags
[2]: https://wiki.debian.org/HardeningWalkthrough
[3]: https://wiki.debian.org/Hardening
- -- System Information:
Debian Release: wheezy/sid
APT prefers unstable
APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)
Kernel: Linux 3.2.0-1-amd64 (SMP w/8 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)
iQIcBAEBCAAGBQJPVkb/AAoJEJL+/bfkTDL5DjsP/3Rxsg3/vQaYGC4PcGA1H+1d
q+1bg8ix7QgWTPfQxNr9KGCdDplPlPR1zM2YThm+Aw30Rh0BxhUacg2ddEYBqCYN
L8SLZQi646T8mZ7luK4MStgQu7D9TJtnsHzmN72H4mhWfUunQu4V+Ykd0l6/Rpuu
bNPAV6SvrOxhRSYqpwyEwolQoiXzPbr24xo+8Jz714T9bC0FCrNXMaXPqpy6IpUw
a3A3dbjkZXVDPgsveguqb/Oymzz1mzXYd6gGYOqMo4E+3wqaIpuklXyAJrlnawGK
nMDZne0Hx6t6zDwl2gZeADO/8JSDryAGTMwBPfZn30nogEnHDUtA13R9FJnHZ5Pt
IL0ZwTwP8N1X9/gdvxDh2ypivZ0PuTu4j45pjq0rewXPjME4EnCwUISNRCgga10E
QZBY18lNvm5mGBLPWiVi8UTKlcJskMvU7vf/42hOrXdZN+2AesLUDo4E9synnfRh
pG9tuS0rShvrdZNem/iwtKVwlZsi+QDGlVdvF0jFCeC9U8NSIKbsLIBfldSDgkZn
USaamhQDrs1zZQL0ZDpUAzhmWDJAvA4y5mgevSa12TKrlRLrZrY7edI1s02P5PBj
xSoQ8q28xGeSdTkt2Xy4XETJbFgxz+mnG4T42C9swBvPhHrhte/9Qzfku59iG41f
w6aCyn7cm25PkCEku200
=3ZWp
-----END PGP SIGNATURE-----
--
To UNSUBSCRIBE, email to [email protected]
with a subject of "unsubscribe". Trouble? Contact [email protected]
