Package: icinga-cgi
Version: 1.6.1-2
Severity: wishlist
Tags: patch

Hi.

Attached is a patch that IMHO, improves the shipped example config for apache.
Especially the ScriptAlias seems to be not necessari, given that you compile
icinga-cgi with --with-cgiurl=/cgi-bin/icinga .
At least I could not find any reference to any /icinga/cgi-bin/ path.


May I further propose to not place the apache.conf in /etc/icinga ?

Either it's unused as the user handles this himself, or if used, it could
be integrated in /etc/apache2/sites-available ?


Cheers,
Chris.
* Cosmetic cleanups.
* Tightening the regular expression.
* Drop useless ScriptAlias.
--- a/debian/apache2.conf
+++ b/debian/apache2.conf
@@ -1,7 +1,6 @@
 # apache configuration for icinga
 
 ScriptAlias /cgi-bin/icinga /usr/lib/cgi-bin/icinga
-ScriptAlias /icinga/cgi-bin /usr/lib/cgi-bin/icinga
 
 # Where the stylesheets (config files) reside
 Alias /icinga/stylesheets /etc/icinga/stylesheets
@@ -9,7 +8,7 @@
 # Where the HTML pages live
 Alias /icinga /usr/share/icinga/htdocs
 
-<DirectoryMatch (/usr/share/icinga/htdocs|/usr/lib/cgi-bin/icinga|/etc/icinga/stylesheets)>
+<DirectoryMatch "^(/usr/share/icinga/htdocs|/usr/lib/cgi-bin/icinga|/etc/icinga/stylesheets)">
 	Options FollowSymLinks
 
 	DirectoryIndex index.html
@@ -21,5 +20,5 @@
 	AuthName "Icinga Access"
 	AuthType Basic
 	AuthUserFile /etc/icinga/htpasswd.users
-	require valid-user
+	Require valid-user
 </DirectoryMatch>

Reply via email to