Package: fonts-f500
Version: 1.0-3
Severity: wishlist
Tags: patch
User: [email protected]
Usertags: origin-ubuntu ubuntu-patch precise
Using 'dpkg-maintscript-helper supports rm_conffile' guards introduces
unreliability into upgrades; it means that the conffile is removed or
not depending on whether dpkg happens to be unpacked before fonts-f500.
This seems generally undesirable; it would be better to enforce a single
code path. (This is academic for Debian because the version of dpkg in
squeeze supported dpkg-maintscript-helper, hence Severity: wishlist;
Ubuntu's last LTS release didn't have a sufficient version of dpkg for
that which is why I care.)
It would be nice to just use dh_installdeb's support for generating
dpkg-maintscript-helper commands, which was introduced in debhelper
8.1.0. This would remove duplicate code from your maintainer scripts -
in fact, you'd no longer need to have handwritten maintainer scripts at
all. Here's a patch:
* Use maintscript support in dh_installdeb rather than writing out
dpkg-maintscript-helper commands by hand. We now simply Pre-Depend on a
new enough version of dpkg rather than using 'dpkg-maintscript-helper
supports' guards, leading to more predictable behaviour on upgrades.
diff -Nru fonts-f500-1.0/debian/control fonts-f500-1.0/debian/control
--- fonts-f500-1.0/debian/control 2011-10-13 13:56:15.000000000 +0100
+++ fonts-f500-1.0/debian/control 2012-02-12 00:51:13.000000000 +0000
@@ -3,11 +3,12 @@
Priority: optional
Maintainer: Debian Fonts Task Force <[email protected]>
Uploaders: Gürkan Sengün <[email protected]>
-Build-Depends-Indep: debhelper (>= 8)
+Build-Depends-Indep: debhelper (>= 8.1.0~)
Standards-Version: 3.9.2
Package: fonts-f500
Architecture: all
+Pre-Depends: ${misc:Pre-Depends}
Depends: ${misc:Depends}
Replaces: ttf-f500 (<< 1.0-2)
Conflicts: ttf-f500 (<< 1.0-2)
diff -Nru fonts-f500-1.0/debian/maintscript fonts-f500-1.0/debian/maintscript
--- fonts-f500-1.0/debian/maintscript 1970-01-01 01:00:00.000000000 +0100
+++ fonts-f500-1.0/debian/maintscript 2012-02-12 00:50:30.000000000 +0000
@@ -0,0 +1 @@
+rm_conffile /etc/defoma/hints/ttf-f500.hints 1.0-2
diff -Nru fonts-f500-1.0/debian/postinst fonts-f500-1.0/debian/postinst
--- fonts-f500-1.0/debian/postinst 2011-07-21 21:17:25.000000000 +0100
+++ fonts-f500-1.0/debian/postinst 1970-01-01 01:00:00.000000000 +0100
@@ -1,9 +0,0 @@
-#!/bin/sh
-set -e
-
-if dpkg-maintscript-helper supports rm_conffile 2>/dev/null; then
- dpkg-maintscript-helper rm_conffile /etc/defoma/hints/ttf-f500.hints 1.0-2
-- "$@"
-fi
-
-#DEBHELPER#
-
diff -Nru fonts-f500-1.0/debian/postrm fonts-f500-1.0/debian/postrm
--- fonts-f500-1.0/debian/postrm 2011-07-21 21:17:45.000000000 +0100
+++ fonts-f500-1.0/debian/postrm 1970-01-01 01:00:00.000000000 +0100
@@ -1,9 +0,0 @@
-#!/bin/sh
-set -e
-
-if dpkg-maintscript-helper supports rm_conffile 2>/dev/null; then
- dpkg-maintscript-helper rm_conffile /etc/defoma/hints/ttf-f500.hints 1.0-2
-- "$@"
-fi
-
-#DEBHELPER#
-
diff -Nru fonts-f500-1.0/debian/preinst fonts-f500-1.0/debian/preinst
--- fonts-f500-1.0/debian/preinst 2011-07-21 21:17:49.000000000 +0100
+++ fonts-f500-1.0/debian/preinst 1970-01-01 01:00:00.000000000 +0100
@@ -1,9 +0,0 @@
-#!/bin/sh
-set -e
-
-if dpkg-maintscript-helper supports rm_conffile 2>/dev/null; then
- dpkg-maintscript-helper rm_conffile /etc/defoma/hints/ttf-f500.hints 1.0-2
-- "$@"
-fi
-
-#DEBHELPER#
-
Thanks,
--
Colin Watson [[email protected]]
--
To UNSUBSCRIBE, email to [email protected]
with a subject of "unsubscribe". Trouble? Contact [email protected]
