tags 89902 upstream confirmed patch
thanks
I hereby confirm that #89902 is still there in 4.0.12.
When a user's last login failure happened more than 7 days ago, the
failure log message is way too terse:
1 failure since last login. Last was Wednesday 15:27:53 on pts/2.
Indeed, I don't really see the point in showing only the year if the
last unsuccessful login attempt was mor ethan 1 year ago, the week day
and time of it was more than 1 day ago and only the time otherwise.
IMHO, login should give the full information, that is "%c" as defined
in date.
The attached patch proposes such a change. It only acts in "#if HAVE_STRFTIME
" part as I don't really know how the other part works.
Tomasz, please mention us whether you intend to apply this...or a
similar change.
--
--- failure.c.ori 2005-09-26 18:49:35.698008372 +0200
+++ failure.c 2005-09-26 19:56:25.811823160 +0200
@@ -197,16 +197,10 @@
#if HAVE_STRFTIME
/*
- * Only print as much date and time info as it needed to
- * know when the failure was.
+ * Print all information we have.
*/
- if (NOW - fail->fail_time >= YEAR)
- fmt = "%Y";
- else if (NOW - fail->fail_time >= DAY)
- fmt = "%A %T";
- else
- fmt = "%T";
+ fmt = "%c";
strftime (lasttimeb, sizeof lasttimeb, fmt, tp);
#else
