On Thu, Feb 02, 2012 at 11:20:20AM +0100, Roland Clobus wrote:
> Hello,
>
> On Sun, 2012-01-29 at 10:54 +0100, Moritz Muehlenhoff wrote:
> > Please enable hardened build flags through dpkg-buildflags.
> >
> > Patch attached. (dpkg-buildflags abides "noopt" from DEB_BUILD_OPTIONS)
>
> Thanks for the patch. I've looked at the wiki pages and it is not clear
> whether it is sufficient for upstream to include the hardening options
> in the configure.ac file.
You could do that, but that would probably cause problems for people
building Pioneers with a compiler different from gcc.
> Or should the debian/rules file explicitly
> turn on the hardening flags too? (Thus in effect turning on the same
> compiler and linker flags for the second time)
Independant of what new defaults you set in configure.ac, you should
keep the dpkg-buildflag calls. They allow people to easily rebuild
Debian systems with new standard flags and it allows to to fine-fune
the standard flags if changes are needed.
Cheers,
Moritz
--
To UNSUBSCRIBE, email to [email protected]
with a subject of "unsubscribe". Trouble? Contact [email protected]
