On 01/04/2012 07:18 PM, Antti Kaihola wrote:
2012/1/4 Kartik Mistry <[email protected]
<mailto:[email protected]>>
> Ok. adding it with next commit.
But:
https://github.com/vkholodkov/nginx-upload-module/issues/26#issuecomment-3357444
so, holding off upload until upstream resolves issue.
Makes sense. On the surface it looks like a simple issue. Let's hope
nothing nasty is hiding behind it :)
Despite their similar names, the upload and uploadprogress modules
serve indeed very different purposes. Uploadprogress is for tracking
conventional uploads with AJAX polling, whereas the upload module
handles the entire file transfer procedure before handing the
resulting uploaded file to the web application.
Thanks for accepting this proposal!
Good evening.
Apparently, upstream was doing nothing.
But I decided to go on and apply the fix I proposed. Maybe this will
motivate him to apply a fix in the GIT repo.
I also took this decision because I tested the module over the last 2
weeks (with nginx 1.1.13) on an internal service in my company, no
issues were reported by users, and nothing bad in the log files, so I
consider the build issue was minor, and thus not affecting the overall
functioning of the module.
I also answered in the issue on github.
Thanks.
--
Cyril "Davromaniak" Lavier
