Hi, all.

2012/1/28 gregor herrmann <[email protected]>:
> On Fri, 27 Jan 2012 20:24:00 +0100, Jakub Wilk wrote:
>
>> >+#if PNG_LIBPNG_VER_MAJOR >= 1 && PNG_LIBPNG_VER_MINOR >= 4
>> >+    png_set_expand_gray_1_2_4_to_8(h->png);
>> >+#else
>> >     png_set_gray_1_2_4_to_8(h->png);
>> >+#endif
>>
>> Won't that break with libpng 2.0? I think it the condition should be
>> rather:
>> (PNG_LIBPNG_VER_MAJOR == 1 && PNG_LIBPNG_VER_MINOR >= 4) || 
>> PNG_LIBPNG_VER_MAJOR > 1
>
> Good question.
>
> Let's ask the sumbitter/libpng maintainer:
> Nobuhiro, what dou think?
>

I think that it is better for Jakub to point out.
But "| | PNG_LIBPNG_VER_MAJOR > 1" was unnecessary, I think.

Best regards,
  Nobuhiro

-- 
Nobuhiro Iwamatsu
   iwamatsu at {nigauri.org / debian.org}
   GPG ID: 40AD1FA6



--
To UNSUBSCRIBE, email to [email protected]
with a subject of "unsubscribe". Trouble? Contact [email protected]

Reply via email to