tags 654218 +patch
thanks
https://buildd.debian.org/status/fetch.php?pkg=libgconf-bridge&arch=armhf&ver=0.1-2&stamp=1322967516
<https://buildd.debian.org/status/fetch.php?pkg=libgconf-bridge&arch=armhf&ver=0.1-2&stamp=1322967516>
The package fails to build on armhf and s390x, but I've reproduced the exact
error on a sid amd64 system, so tagging this as serious.
Konstantinos
The attatched patches fixes the format security issue and a link error with a
test that I ran into.
after fixing the format security error.
diff -ur libgconf-bridge-0.1/tests/Makefile.am libgconf-bridge-0.1.new/tests/Makefile.am
--- libgconf-bridge-0.1/tests/Makefile.am 2005-11-28 13:12:35.000000000 +0000
+++ libgconf-bridge-0.1.new/tests/Makefile.am 2012-01-08 03:22:24.000000000 +0000
@@ -1,6 +1,6 @@
AM_CPPFLAGS=-DPKGDATADIR=\"$(pkgdatadir)\" -DGETTEXT_PACKAGE=\"libgconf-bridge\"
AM_CFLAGS = -Wall -g $(LIBGCONF_BRIDGE_CFLAGS) \
- -I$(top_srcdir) -I$(top_builddir) -Werror
+ -I$(top_srcdir) -I$(top_builddir) -Werror -lgconf-2
noinst_PROGRAMS = test
diff -ur libgconf-bridge-0.1/tests/Makefile.in libgconf-bridge-0.1.new/tests/Makefile.in
--- libgconf-bridge-0.1/tests/Makefile.in 2006-02-16 10:32:29.000000000 +0000
+++ libgconf-bridge-0.1.new/tests/Makefile.in 2012-01-08 03:22:52.000000000 +0000
@@ -193,7 +193,7 @@
target_alias = @target_alias@
AM_CPPFLAGS = -DPKGDATADIR=\"$(pkgdatadir)\" -DGETTEXT_PACKAGE=\"libgconf-bridge\"
AM_CFLAGS = -Wall -g $(LIBGCONF_BRIDGE_CFLAGS) \
- -I$(top_srcdir) -I$(top_builddir) -Werror
+ -I$(top_srcdir) -I$(top_builddir) -Werror -lgconf-2
test_SOURCES = test.c
test_LDADD = $(top_builddir)/libgconf-bridge/libgconf-bridge.la
diff -ur libgconf-bridge-0.1/libgconf-bridge/gconf-bridge.c libgconf-bridge-0.1.new/libgconf-bridge/gconf-bridge.c
--- libgconf-bridge-0.1/libgconf-bridge/gconf-bridge.c 2005-12-15 12:13:36.000000000 +0000
+++ libgconf-bridge-0.1.new/libgconf-bridge/gconf-bridge.c 2012-01-08 03:08:19.000000000 +0000
@@ -1169,16 +1169,13 @@
g_warning ("GConf error:\n %s", error->message);
if (!shown_dialog) {
- char *message;
GtkWidget *dlg;
- message = g_strdup_printf (_("GConf error: %s"),
- error->message);
dlg = gtk_message_dialog_new (NULL, 0,
GTK_MESSAGE_ERROR,
GTK_BUTTONS_OK,
- message);
- g_free (message);
+ _("GConf error: %s"),
+ error->message);
gtk_message_dialog_format_secondary_text
(GTK_MESSAGE_DIALOG (dlg),
