severity 486527 minor
retitle 486527 SVN::Ra::new: colon instead of period in message for tunnel 
connection problems
reassign 486527 libsvn1 1.6.17dfsg-3
quit

Hi,

> Quentin Neill wrote:

>> Setup an account on a remote system with /bin/false as a login shell:
>> 
>> remote# useradd -s /bin/false blah
>> remote# passwd blah
>> ...
>> 
>> Try something that tickles the SVN/Core.pm code from the local system:
>> local# git svn init -Ttrunk svn+ssh://blah@remote/junk
>> ...

Thanks again for the reproduction recipe.  With libsvn-perl
1.6.17dfsg-3:

        $ git svn init -Ttrunk svn+ssh://blah@localhost/junk
        blah@localhost's password: 
        Network connection closed unexpectedly: To better debug SSH connection 
problems, remove the -q option from 'ssh' in the [tunnels] section of your 
Subversion configuration file. at /usr/lib/git-core/git-svn line 2299

So the cause (svn_error_t with NULL message) is still present and
still produces a weird symptom.  This time the symptom is less severe
than before: a goofy error message with colon promising explanation
and no delivery.  So the fix to bug#422699 indeed improved things.

The svn_error_t comes from subversion/libsvn_ra_svn/marshal.c, in
readbuf_input():

  SVN_ERR(svn_ra_svn__stream_read(conn->stream, data, len));
  if (*len == 0)
    return svn_error_create(SVN_ERR_RA_SVN_CONNECTION_CLOSED, NULL, NULL);

This regression seems to have come about in r870846.  I'm not familiar
enough with libsvn to say if libsvn should be putting a message in the
svn_error_t object or the bindings should use a period instead of a
colon when the message is not present.

Hope that helps,
Jonathan



-- 
To UNSUBSCRIBE, email to [email protected]
with a subject of "unsubscribe". Trouble? Contact [email protected]

Reply via email to