On Wed, 2011-12-14 at 14:34 +0200, أحمد المحمودي (Ahmed El-Mahmoudy) wrote: > On Wed, Dec 14, 2011 at 04:31:24AM +0000, Ben Hutchings wrote: > > Sorry, no it isn't. You have to test for CONFIG_X86_32 inside of > > Kbuild, and you can't use uname for this anywhere. > > Can you further explain this please ?
1. You run 'make' in the drivers directory. 2. This invokes the kernel build system (Kbuild). 3. Kbuild includes the Makefile from the drivers directory again. Steps 1 and 3 can be distinguished by whether KERNELRELEASE is defined. At step 3, CONFIG_X86_32 is defined or not, as appropriate. At step 1, you can't tell. Testing uname is no good because that tells you about the host kernel and not the target kernel. Well, you could include $(KERNEL_DIR)/.config at step 1. > > Really, the Makefile needs a thorough cleanup. > > Actually, I don't want to remove the 2.4.x kernel support. Whyever not? > > Also, building for a 64-bit kernel will still fail since DKMS is > > configured to expect all 3 modules to be built. > > Actually sl-modem-source is only for i386 arch, but your dkms.conf patch > is wonderful, I didn't know that it was possible, I have cherry-picked > this patch already, and hence made sl-modem-source available for amd64 > arch too. Well the USB driver ought to work on any architecture, right? Ben. -- Ben Hutchings Computers are not intelligent. They only think they are.
signature.asc
Description: This is a digitally signed message part
