Hi Mats!
Mats Erik Andersson wrote:
> I did a quick review of the IPv6 patch as presented by PTS.
> There is a grave misconception in the modification of
> "links2/default.c":
>
> A single character variable is allocated, yet it is
> used in storing and printing strings:
>
> char addr;
>
> unsigned char *p = (...) &addr;
>
> do_real_lookup(*(*argv -1), &addr) /* Inside conditional statement */
>
> printf("%s\n", addr); /* [sic!] char used as pointer */
>
> Observing that this latter statement is replacing the old call
>
> printf("%d.%d.%d.%d\n", p[0], p[1], p[2], p[3]);
Thanks a lot for that pointer! (sic! :-)
> it is fairly obvious that the code is playing games with IPv4 addresses.
Well, I looked for such an issue several times and did not see it.
I'm on holidays next week and hope to find time to tackle this issue.
(Patches for the patch are of course welcome anyway. :-)
Regards, Axel
--
,''`. | Axel Beckert <a...@debian.org>, http://people.debian.org/~abe/
: :' : | Debian Developer, ftp.ch.debian.org Admin
`. `' | 1024D: F067 EA27 26B9 C3FC 1486 202E C09E 1D89 9593 0EDE
`- | 4096R: 2517 B724 C5F6 CA99 5329 6E61 2FF9 CD59 6126 16B5
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
