Package: exiftran
Version: 2.07-6
Severity: normal
Tags: patch
Exiftran exits on fchown() error. This error occurs on filesystems which do
not support file ownership or permissions such as FAT.
It may still display an error message, but should not exit for such a tiny
problem, whithout having processed the image(s).
reproduce with: 'exiftran -ai *.jpg' (on a FAT fs for example)
Thanks.
-- System Information:
Debian Release: 6.0.3
APT prefers stable-updates
APT policy: (500, 'stable-updates'), (500, 'stable')
Architecture: amd64 (x86_64)
Kernel: Linux 3.0.4 (SMP w/2 CPU cores)
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Versions of packages exiftran depends on:
ii libc6 2.11.2-10 Embedded GNU C Library: Shared lib
ii libexif12 0.6.19-1 library to parse EXIF files
ii libjpeg62 6b1-1 The Independent JPEG Group's JPEG
exiftran recommends no packages.
exiftran suggests no packages.
-- no debconf information
--- fbi-2.07/jpegtools.c 2006-06-13 14:47:24.000000000 +0200
+++ fbi-2.07_patched/jpegtools.c 2011-10-19 01:42:59.498275393 +0200
@@ -570,18 +570,16 @@ int jpeg_transform_inplace(char *file,
}
out = fdopen(fd,"w");
- /* copy owner and permissions */
+ /* copy owner and permissions (if possible with the filesystem) */
if (-1 == fstat(fileno(in),&st)) {
fprintf(stderr,"fstat(%s): %s\n",file,strerror(errno));
goto oops;
}
if (-1 == fchown(fileno(out),st.st_uid,st.st_gid)) {
fprintf(stderr,"fchown(%s): %s\n",tmpfile,strerror(errno));
- goto oops;
}
if (-1 == fchmod(fileno(out),st.st_mode)) {
fprintf(stderr,"fchmod(%s): %s\n",tmpfile,strerror(errno));
- goto oops;
}
/* transform */
