Package: cups
Version: 1.5.0-8.01
Severity: normal
Tags: upstream patch
I am trying to locate a bug in cups which currently looks like a
broken pipe. After attempts to write to a socket, an http status
of HTTP_ERROR is returned which does not have a case in the relevant
switch statement in cups/http-support.c.
As a result, the unhelpful default message "Unknown" is passed back to the
user who is none the wiser.
The attached patch improves the default message, and adds an extra
branch for HTTP_ERROR. There should perhaps be further cases for
other values in http.h which are not covered explicitly.
----------------------------------------------------------------------------
-- System Information:
Debian Release: wheezy/sid
APT prefers testing
APT policy: (990, 'testing')
Architecture: i386 (i686)
Kernel: Linux 3.1.0-rc4+ (PREEMPT)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8) (ignored: LC_ALL
set to en_GB.UTF-8)
Shell: /bin/sh linked to /bin/bash
Versions of packages cups depends on:
ii adduser 3.113
ii bc 1.06.95-2
ii cups-client 1.5.0-8.01
ii cups-common 1.5.0-8.01
ii cups-ppdc 1.5.0-8.01
ii debconf [debconf-2.0] 1.5.40
ii ghostscript 9.04~dfsg-2
ii libacl1 2.2.51-3
ii libavahi-client3 0.6.30-5
ii libavahi-common3 0.6.30-5
ii libc6 2.13-21
ii libcups2 1.5.0-8.01
ii libcupscgi1 1.5.0-8.01
ii libcupsdriver1 1.5.0-8.01
ii libcupsimage2 1.5.0-8.01
ii libcupsmime1 1.5.0-8.01
ii libcupsppdc1 1.5.0-8.01
ii libdbus-1-3 1.4.16-1
ii libgcc1 1:4.6.1-4
ii libgnutls26 2.12.11-1
ii libgssapi-krb5-2 1.9.1+dfsg-1
ii libijs-0.35 0.35-8
ii libkrb5-3 1.9.1+dfsg-1
ii liblcms1 1.19.dfsg-1+b1
ii libldap-2.4-2 2.4.25-3
ii libpam0g 1.1.3-4
ii libpaper1 1.1.24+nmu1
ii libpoppler13 0.16.7-2+b1
ii libslp1 1.2.1-7.8
ii libstdc++6 4.6.1-4
ii libusb-0.1-4 2:0.1.12-19
ii lsb-base 3.2-28
ii poppler-utils 0.16.7-2+b1
ii procps 1:3.2.8-11
ii ssl-cert 1.0.28
ii ttf-freefont 20100919-1
ii zlib1g 1:1.2.3.4.dfsg-3
Versions of packages cups recommends:
ii avahi-daemon 0.6.30-5
ii colord 0.1.11-1
ii cups-driver-gutenprint 5.2.7-2
ii foomatic-filters 4.0.9-1
ii ghostscript-cups 9.04~dfsg-2
Versions of packages cups suggests:
ii cups-bsd 1.5.0-8.01
ii cups-pdf <none>
ii foomatic-db 20110831-1
ii hplip <none>
ii smbclient 2:3.5.11~dfsg-1
ii udev 172-1
-- Configuration Files:
/etc/cups/cupsd.conf changed [not included]
-- debconf information excluded
diff -ur a//cups/http-support.c b//cups/http-support.c
--- a//cups/http-support.c 2011-10-15 22:13:35.000000000 +0100
+++ b//cups/http-support.c 2011-10-15 22:10:43.000000000 +0100
@@ -1335,9 +1335,12 @@
case HTTP_WEBIF_DISABLED :
s = _("Web Interface is Disabled");
break;
+ case HTTP_ERROR :
+ s = _("http error");
+ break;
default :
- s = _("Unknown");
+ s = _("Unknown http status");
break;
}
