Package: backupninja
Version: 0.9.9-1
Tags: patch

The rsync helper calls all rsync options as one *argv argument, like
so:

 execve("/usr/bin/nice", ["nice", "-n", "0", "/usr/bin/rsync", "-av
   --delete --recursive --numer"..., "--exclude=/var/bkah"...,

The rdiff helper uses "sh -c" to expand this, so we can probably
consider that safe enough.

Patch attached.


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      la...@debian.org
       `-
diff --git a/handlers/rsync.in b/handlers/rsync.in
index d93411a..34642d3 100644
--- a/handlers/rsync.in
+++ b/handlers/rsync.in
@@ -1071,7 +1071,7 @@ for SECTION in $include; do
 
   info "Syncing $SECTION on $dest_path..."
   debug $nice $rsync "${rsync_options[@]}" $filelist_flag $excludes 
$batch_option $orig $dest_path
-  $nice $rsync "${rsync_options[@]}" $filelist_flag $excludes $batch_option 
$orig $dest_path | tee -a $log
+  $nice sh -c "$rsync ${rsync_options[@]} $filelist_flag $excludes 
$batch_option $orig $dest_path" | tee -a $log
 
   if [ "$?" != "0" ]; then
     warning "Rsync error when trying to transfer $SECTION"

Attachment: signature.asc
Description: PGP signature

Reply via email to