Thorsten Glaser wrote:
> Please look at the attached build log and tell me it's a recursive
> make invocation loop I'm seeing. (That's how I'm interpreting it.)
That's embarrassing. Thanks for reporting it.
-- >8 --
Subject: debian/rules: avoid infinite makefile loop with
DEB_BUILD_OPTIONS=nocheck
When the list of test_targets is empty, the rules for build-arch
simply run
make -f debian/rules
which invokes the default target, which depends on build-arch.
Oops.
Fixes: http://bugs.debian.org/638071
Reported-by: Thorsten Glaser <[email protected]>
---
debian/changelog | 8 ++++++++
debian/rules | 4 +++-
2 files changed, 11 insertions(+), 1 deletions(-)
diff --git a/debian/changelog b/debian/changelog
index 4435cc3..6d6e978 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,11 @@
+xz-utils (5.5.1alpha+20110809-1.1) unstable; urgency=low
+
+ * debian/rules build-arch: Do not trigger an infinite "make"
+ recursion loop when DEB_BUILD_OPTIONS=nocheck. Closes: #638071.
+ Thanks to Thorsten Glaser for reporting it.
+
+ -- Jonathan Nieder <[email protected]> Tue, 16 Aug 2011 17:51:12 -0500
+
xz-utils (5.1.1alpha+20110809-1) unstable; urgency=low
* New snapshot, taken from upstream commit 5c5b225.
diff --git a/debian/rules b/debian/rules
index 600311d..8c30269 100755
--- a/debian/rules
+++ b/debian/rules
@@ -74,6 +74,8 @@ debian/xzdec-build/Makefile: $(configure_input)
$(autoreconf_products): $(autoreconf_sources)
autoreconf -is
+noop: ;
+
opt_optimize = CFLAGS="-g -O2"
opt_optimize_small = CFLAGS="-g -Os"
opt_no_act =
@@ -110,7 +112,7 @@ ifneq (,$(filter quiet,$(DEB_BUILD_OPTIONS)))
endif
ifneq (,$(filter nocheck,$(DEB_BUILD_OPTIONS)))
- test_targets =
+ test_targets = noop
endif
# Build a tarball with the latest upstream version.
--
1.7.6
--
To UNSUBSCRIBE, email to [email protected]
with a subject of "unsubscribe". Trouble? Contact [email protected]
