On Thu, Aug 11, 2011 at 03:26:30PM +0100, Neil Williams wrote:
> tag 637434 - patch
> thanks
>
> On Thu, 11 Aug 2011 15:19:12 +0200
> [email protected] wrote:
>
> > > > The (tested) attached patch set APT::Default-Release to the suite
> > > > defined
> > > > in multistrap config.
>
> Which suite in the config? Multistrap explicitly supports as many
> suites as the user wants to configure. The patch can only work if there
> is only one section or if all sections use the same suite. That is not
> acceptable, so I have to reject the patch. e.g. examples already
> in /usr/share/multistrap use two suites, stable cross-building
> toolchains and testing or unstable build environment. See the armel.conf
> example: /usr/share/multistrap/armel.conf - stable toolchains on
> unstable base.
Right, the problem seems a bit more complicated than I first thought.
> I'll have a closer look at this over the weekend, hopefully. There is
> the %suites hash but that is a collection of suites from each section
> defined in the conf. i.e. if you add a new section to the conf file
> with a new suite, which value of $suites[$sect] is to be used as the
> default?
>
> @@ -329,6 +329,9 @@ if (defined $deflist) {
> $sourcesname = "sources.list.d/multistrap.sources.list";
> $config_str .= " -o Dir::Etc::SourceList=${dir}${etcdir}$sourcesname";
> }
> +if (defined $suite) {
> + $config_str .= " -o APT::Default-Release=$suite";
> +}
>
> There would probably have to be a [General] setting, if this is
> actually necessary.
Seems the most generic solution. It might makes sense even to have a way
to define the default suite for the root filesystem, that can then be
overriden as needed in other sections.
> Current SVN removes the global scope of $suite, $mirror and $component
> because these should only be local variables during the looping through
> the @aptsources and @debootstrap arrays.
Thanks to spend some time on this.
Bert.
--
To UNSUBSCRIBE, email to [email protected]
with a subject of "unsubscribe". Trouble? Contact [email protected]
