Package: inoticoming
Version: 0.2.2-1
Severity: minor
The example init.d script is written to have LOGFILE be an optional element.
if [ -n $LOGFILE ] ; then
[ -f $LOGFILE ] || touch $LOGFILE
chown $USER $LOGFILE
OPTIONS="$OPTIONS --logfile $LOGFILE"
fi
However that construct doesn't handle an empty LOGFILE due to
insufficient variable quoting. The $LOGFILE disappears if it isn't
set. That variable needs to be quoted for this construct to work as
intended.
- if [ -n $LOGFILE ] ; then
+ if [ -n "$LOGFILE" ] ; then
Of course this is only an example and so this is only a minor issue.
Also as long as I am suggesting opening up the example init.d file,
log files in /var/log are generally group 'adm'. It would be great if
that were continued.
- chown $USER $LOGFILE
+ chown $USER:adm $LOGFILE
Also, as an aside at an even more minor level, there is some extra
whitespace in the script. It would be super nice if that were cleaned
for the next upload too.
Thanks for maintaining inoticoming.
Bob
--
To UNSUBSCRIBE, email to [email protected]
with a subject of "unsubscribe". Trouble? Contact [email protected]
