Package: xawtv
Version: 3.95.dfsg.1-8.1
Severity: normal
Tags: patch
User: [email protected]
Usertags: origin-ubuntu oneiric ubuntu-patch

In the ubuntu archive built with ld --as-needed --no-add-needed the plugins,
lt-disor flt-gamma and conv-mjpeg are missing links against libm and libjpeg
preventing them from being loaded by dlopen. Upstream build probably relied on
indirect linkage from other dependencies.
See https://bugs.launchpad.net/ubuntu/+source/xawtv/+bug/821916

Attached patch fixes this problem by explicitly linking the plugins with the
needed libraries.

Thanks for considering the patch.



-- System Information:
Debian Release: squeeze/sid
  APT prefers natty-updates
  APT policy: (500, 'natty-updates'), (500, 'natty-security'), (500, 
'natty-proposed'), (500, 'natty'), (100, 'natty-backports')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.38-11-generic (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
=== modified file 'debian/patches/00list'
--- debian/patches/00list       2011-01-09 17:14:14 +0000
+++ debian/patches/00list       2011-08-06 21:19:18 +0000
@@ -20,3 +20,4 @@
 101_fedora-nodga.dpatch
 102_fedora-use_libv4l.dpatch
 103_fix_ftbfs_no-add-needed.dpatch
+104_fix_plugin_links.dpatch

=== added file 'debian/patches/104_fix_plugin_links.dpatch'
--- debian/patches/104_fix_plugin_links.dpatch  1970-01-01 00:00:00 +0000
+++ debian/patches/104_fix_plugin_links.dpatch  2011-08-06 21:22:06 +0000
@@ -0,0 +1,19 @@
+#! /bin/sh /usr/share/dpatch/dpatch-run
+## Description: link plugins against libma and libjpeg
+## Author: Julian Taylor <[email protected]>
+## Bug: https://bugs.launchpad.net/ubuntu/+source/xawtv/+bug/821916
+
+@DPATCH@
+diff -urNad '--exclude=CVS' '--exclude=.svn' '--exclude=.git' 
'--exclude=.arch' '--exclude=.hg' '--exclude=_darcs' '--exclude=.bzr' 
xawtv-3.95.dfsg.1~/libng/plugins/Subdir.mk 
xawtv-3.95.dfsg.1/libng/plugins/Subdir.mk
+--- xawtv-3.95.dfsg.1~/libng/plugins/Subdir.mk 2003-02-14 14:14:05.000000000 
+0000
++++ xawtv-3.95.dfsg.1/libng/plugins/Subdir.mk  2011-08-06 20:51:42.628830920 
+0000
+@@ -42,6 +42,9 @@
+ libng/plugins/read-dv.so  : LDLIBS := $(DV_LIBS)
+ libng/plugins/write-dv.so : LDLIBS := $(DV_LIBS)
+ libng/plugins/drv0-v4l2.so: LDLIBS := -lv4l2
++libng/plugins/flt-disor.so: LDLIBS := -lm
++libng/plugins/flt-gamma.so: LDLIBS := -lm
++libng/plugins/conv-mjpeg.so: LDLIBS := -ljpeg
+ 
+ # global targets
+ all:: $(TARGETS-plugins)

Reply via email to