On Tue, 12 Jul 2011 20:08:30 +0800, Thomas Goirand <[email protected]> wrote: > > > It assumes I have ssh installed. If I don't, the script terminates early > > with > > an error. > > Sure, it assumes sshd to be installed: that's the hole point of the > script! Do you think it should be made more explicit? If so, please > suggest something else that what is already in the Debconf template: >
This doesn't seem to be the whole point of the script. The script is doing several things. But in any case, if this script needs to be run to complete the installation of this package, and this script cannot execute without openssh-server installed, then you need to depend on openssh-server. > > The script does a poor job of interpreting /etc/ssh/sshd_config: > > grep "AllowTcpForwarding no" /etc/ssh/sshd_config > > is not a reliable way to see if TCPForwarding is disabled. If that fails, > > then > > grep "AllowTcpForwarding" /etc/ssh/sshd_config > > is not a reliable way to see if TCPForwarding is enabled. > > Remember that the goal is to provide a helper to quickly disable port > forwarding. It does work on a freshly installed server. I don't mind > improving the script if you can think of improvements. How would you do > it then? Do you understand why these are currently inadequate? If so, I'd hope they'd be trivial to imporove. > > The script checks to see what stuff might exist in /usr/share/dtc-xen-os, > > which > > doesn't seem to be a directory in any debian package. I don't seem to find > > any > > documentation that tells me what might go there. > > The /usr/share/dtc-xen-os is a repository of OS templates that can be > installed automatically by dtc-xen (see "man dtc_reinstall_os", > particularly the -os option). Of course, these aren't available in > Debian, I don't see the security team doing the security updates of > other distributions (and frankly, the images we provide are on the best > effort basis, some should be upgraded). > dtc_reinstall_os would download them? how do I do that? Am I to understand that I would run dtc_reinstall_os with some parameters after installing the package, but before running dtc-xen_finish_install? If so, shouldn't this be mentioned somewhere? (If it is, please show me where). > > Then you tell the user that they should add a sources.list entry for a third > > party repsitory which seems to have packages for lenny ?!? Why is this. > > Are > > there packages in this repository that are needed for using dtc-xen? > > Yes, see above. The packages in the repository for Lenny are working > without any issue in any Debian release anyway, it's just some tar.gz > and some tiny scripts to do the setup of these images. Is it the case that we can expect any user of this software to want those scripts and .tar.gzs? > > > It appears that since /usr/share/dtc-xen-os doens't exist, you will then > > tell the user to run: > > "apt-get install" > > > > Which seems rather pointless. were you going to tell them to apt-get > > update? > > apt-key add? > > The idea is to give pointers to the user that there are some image > templates available. I agree that the message needs to be updated, and I > will. But now, do you really think that an administrator wouldn't know > how to use apt? Well, the rest of this script is making assumptions that given pointers the administrator isn't able to make changes to sudoers or sshd_config, so, I dunno, you tell me. > > Thomas
pgp0XgVngZwpz.pgp
Description: PGP signature
