Package: filezilla
Version: 3.3.5.1-1
Severity: normal
Tags: patch

(I preliminarily applied the patch attached in #631696(another important bug).)

After finished downloading files, Filezilla emits a notify message to the
desktop. But this does not work well if LANG=ja_JP.eucJP. And the following
message is displayed to the terminal twice:
>process 4283: arguments to dbus_message_iter_append_basic() were incorrect, 
>assertion "_dbus_check_is_valid_utf8 (*string_p)" failed in file 
>../../dbus/dbus-message.c line 2526.
>This is normally a bug in some application using the D-Bus library.

The backtrace just before the warning (some Japanese chars are included):
>Breakpoint 2, 0xb7f030b0 in dbus_message_iter_append_basic ()
>   from /lib/libdbus-1.so.3
>(gdb) bt
>#0  0xb7f030b0 in dbus_message_iter_append_basic () from /lib/libdbus-1.so.3
>#1  0x0821ca7c in wxDBusMessage::AddString (this=0x8a07340,
>    value=0x86fa8d0 "転\301\367\275\252了") at wxdbusmessage.cpp:224
>#2  0x08219132 in CDesktopNotificationImpl::EmitNotifications (this=0x8a79568)
>    at desktop_notification.cpp:126
>#3  0x08219519 in CDesktopNotificationImpl::Notify (this=0x8a79568,
>    summary=..., body=..., category=...) at desktop_notification.cpp:101

value=0x86fa8d0 of #1 was encoded by EUC-JP, not UTF-8.
That is incorrect.


Here is a patch to fix this:

--- filezilla-3.3.5.1.orig/src/dbus/desktop_notification.cpp
+++ filezilla-3.3.5.1/src/dbus/desktop_notification.cpp
@@ -123,13 +123,13 @@ void CDesktopNotificationImpl::EmitNotif
        call->AddString("FileZilla");
        call->AddUnsignedInt(0);
        call->AddString("filezilla");
-       call->AddString(notification.summary.mb_str());
-       call->AddString(notification.body.mb_str());
+       call->AddString(notification.summary.mb_str(wxConvUTF8));
+       call->AddString(notification.body.mb_str(wxConvUTF8));
        call->AddArrayOfString(0, 0);

        if (notification.category != _T(""))
        {
-               const wxWX2MBbuf category = notification.category.mb_str();
+               const wxWX2MBbuf category = 
notification.category.mb_str(wxConvUTF8);
                const char *hints[2];
                hints[0] = "category";
                hints[1] = (const char*)category;


-- System Information:
Debian Release: wheezy/sid
  APT prefers testing
  APT policy: (120, 'testing'), (110, 'unstable')
Architecture: i386 (i686)

Kernel: Linux 2.6.38-2-686 (SMP w/1 CPU core)
Locale: LANG=ja_JP.eucJP, LC_CTYPE=ja_JP.eucJP (charmap=EUC-JP)
Shell: /bin/sh linked to /bin/dash

Versions of packages filezilla depends on:
ii  filezilla-common            3.3.5.1-1    Architecture independent files for
ii  libatk1.0-0                 2.0.0-1      The ATK accessibility toolkit
ii  libc6                       2.13-7       Embedded GNU C Library: Shared lib
ii  libcairo2                   1.10.2-6     The Cairo 2D vector graphics libra
ii  libdbus-1-3                 1.4.12-2     simple interprocess messaging syst
ii  libfontconfig1              2.8.0-2.2    generic font configuration library
ii  libfreetype6                2.4.4-1      FreeType 2 font engine, shared lib
ii  libgcc1                     1:4.6.0-10   GCC support library
ii  libgdk-pixbuf2.0-0          2.23.3-3     GDK Pixbuf library
ii  libglib2.0-0                2.28.6-1     The GLib library of C routines
ii  libgnutls26                 2.10.5-1+b1  the GNU TLS library - runtime libr
ii  libgtk2.0-0                 2.24.4-3     The GTK+ graphical user interface
ii  libidn11                    1.20-1       GNU Libidn library, implementation
ii  libpango1.0-0               1.28.3-6     Layout and rendering of internatio
ii  libstdc++6                  4.6.0-10     The GNU Standard C++ Library v3
ii  libwxbase2.8-0              2.8.10.1-3.1 wxBase library (runtime) - non-GUI
ii  libwxgtk2.8-0               2.8.10.1-3.1 wxWidgets Cross-platform C++ GUI t

Versions of packages filezilla recommends:
ii  xdg-utils                    1.1.0~rc1-2 desktop integration utilities from

filezilla suggests no packages.

-- no debconf information



-- 
To UNSUBSCRIBE, email to [email protected]
with a subject of "unsubscribe". Trouble? Contact [email protected]

Reply via email to