tags 631421 + upstream
quit

Hi again,

Philipp Marek wrote:
> Hello Jonathan!

>> Could you elaborate (for example, what error message do you get)?
>
> Starting "git gui" and choosing a chunk to commit gave an error:
>       "fatal: unrecognized whitespace ignore option 'yes'".
>
> The keyword with dash was accepted, and "git apply" had it this way, too.

Ah, I see now that I was confused.  There *is* no
apply.ignore-whitespace option, and the documentation is correct on
that point.  I had confused it for another option when saying the
dashed form is accepted for compatibility; sorry for the sloppiness.

For apply.ignorewhitespace, "yes" is not a recognized value.  The
typical way to stop caring about whitespace distinctions is to set the
value to "change".  That is what the above message is about.  It would
be nice to introduce "all", too, and to make "yes" a synonym for
"change".

Since apply.ignore-whitespace (like apply.jfkdasfd) is not a
recognized option, git does not take it to mean anything and is happy
with it having any value.

> So, which is correct now?

I see a few bugs here:

 - the "[apply] IgnoreWhitespace" option does not accept "true" as a
   value, while it would be reasonable to expect it to

 - the error message for unrecognized values could be clearer

 - the documentation should emphasize somewhere that configuration
   item names are case-insensitive and the usual convention is for
   them never to contain a dash or underscore

> Thank you!

No, thank you. :)  If people never reported these things, the program
would never get any better.

Regards,
Jonathan



-- 
To UNSUBSCRIBE, email to [email protected]
with a subject of "unsubscribe". Trouble? Contact [email protected]

Reply via email to