Daniel Baumann wrote:
> On 06/16/2011 12:44 PM, Jonathan Nieder wrote:

>>  - /etc/init.d/git-daemon is not handled as a configuration file,
>>    which violates policy ยง10.7.3.  I don't think that's a fundamental
>>    problem, but I am not willing to merge this unless it's at least
>>    documented so people do not get bitten by trying to make
>>    customizations.
>
> done in git.

Thanks much!  We're getting much closer.  Some remaining bits:

 - the following sequence results in a running git-daemon:

        install git-daemon-sysvinit
        remove git-daemon-sysvinit (but don't purge it)
        reboot

   It should be possible to avoid this by running
   "update-rc.d git-daemon remove" in prerm when "$1" != upgrade.

 - needs a changelog entry.  Gerrit's usual style is to list all the
   changes there, which can be nice for debugging.  Here's a rough
   attempt; does it look ok to you?

  [ Daniel Baumann ]
  * add an init.d script for git-daemon (closes: #422139).
    * debian/control, debian/rules: new package git-daemon-sysvinit;
      Depends: adduser; Conflicts: git-daemon-run; package git now
      Suggests and git-all Recommends: git-daemon-run |
      git-daemon-sysvinit.
    * debian/git-daemon/sysvinit: new; script to start or stop
      git-daemon.
    * debian/git-daemon/default: new; provide some default settings and
      disable the daemon by default on first installation.
    * debian/git-daemon-sysvinit.README.Debian: new; explain how to get
      started.
    * debian/git-daemon-sysvinit.conffiles: new; treat
      /etc/default/git-daemon, /etc/init.d/git-daemon as conffiles.
    * debian/git-daemon-sysvinit.postinst: new; add gitdaemon system
      user; register and invoke init script to start git-daemon.
    * debian/git-daemon-sysvinit.prerm: new; stops git-daemon.
    * debian/git-daemon-sysvinit.postrm: new; unregisters init script.



--
To UNSUBSCRIBE, email to [email protected]
with a subject of "unsubscribe". Trouble? Contact [email protected]

Reply via email to