On 06/12/2011 06:44 AM, Holger Levsen wrote:
tags 523950 + pending
thanks
Hi Scott,
On Samstag, 11. Juni 2011, Scott Schaefer wrote:
Attached is revised patch. Differs from previous by:
1) single patch file rather than multiple, and
Thanks, I've applied this one now to svn. (It was an easy target :)
2) fixes one typo found during further testing of piuparts-master and
piuparts-slave.
I've read the patch twice but couldnt spot this (and reading the patch is very
repetetive... :) - can you point me to the typo please?!
Thanks& cheers,
Holger
In reserve_package(), call to random.shuffle() must be called with
variable 'plist', not 'vlist' ...
Original (in single file diff.lib.packagesdb.py)
@@ -455,9 +455,9 @@
return self.get_packages_in_state("waiting-to-be-tested")
def reserve_package(self):
- list = self._find_packages_ready_for_testing()
- random.shuffle(list)
- for p in list:
+ plist = self._find_packages_ready_for_testing()
+ random.shuffle(vlist)
+ for p in plist:
if self._logdb.create(self._reserved, p["Package"],
p["Version"], ""):
return p
Corrected, combined patch
@@ -455,9 +455,9 @@
return self.get_packages_in_state("waiting-to-be-tested")
def reserve_package(self):
- list = self._find_packages_ready_for_testing()
- random.shuffle(list)
- for p in list:
+ plist = self._find_packages_ready_for_testing()
+ random.shuffle(plist)
+ for p in plist:
if self._logdb.create(self._reserved, p["Package"],
p["Version"], ""):
--
To UNSUBSCRIBE, email to [email protected]
with a subject of "unsubscribe". Trouble? Contact [email protected]
